Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Package version could not be detected #8

Open
pnadolny13 opened this issue Dec 1, 2022 · 3 comments
Open

Bug: Package version could not be detected #8

pnadolny13 opened this issue Dec 1, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@pnadolny13
Copy link
Contributor

pnadolny13 commented Dec 1, 2022 •
edited
Loading

I noticed that the package version looks to not have been updated when the release tag was created.

Running:

meltano invoke tap-snowflake --version

Returns:

tap-snowflake v[could not be detected], Meltano SDK v0.14.0

Maybe thats what it returns when the version is 0.0.0?

cc @kgpayne
@pnadolny13 pnadolny13 added the bug Something isn't working label Dec 1, 2022
@kgpayne
Copy link
Collaborator

kgpayne commented Dec 6, 2022

Thanks @pnadolny13 🙏 On it here 🙂

@kgpayne kgpayne mentioned this issue Dec 7, 2022
Closed
@pnadolny13
Copy link
Contributor Author

@kgpayne I'm still seeing this even with the changes from meltano/sdk#1241. Or is this repo missing any updates that didnt get pulled in from the SDK changes?

@kgpayne
Copy link
Collaborator

kgpayne commented Jun 27, 2023

Ah, the version detection changes were removed from that PR, in favour of meltano/sdk#1403 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgpayne @pnadolny13