Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should use pooling properly and commit individual groups #140

Open
visch opened this issue Jun 9, 2023 · 0 comments
Open

We should use pooling properly and commit individual groups #140

visch opened this issue Jun 9, 2023 · 0 comments

Comments

@visch
Copy link
Member

visch commented Jun 9, 2023 •
edited
Loading

Right now we're using self.connection directly and not worrying about when to (or not to) commit things to the database. Instead we should be more explicit. Specifically we should create a temp table, do the upsert, and remove the temp table in the same commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@visch