Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support writing full record to a single variant column #100

Open
pnadolny13 opened this issue Jul 27, 2023 · 6 comments
Open

feat: Support writing full record to a single variant column #100

pnadolny13 opened this issue Jul 27, 2023 · 6 comments

Comments

@pnadolny13
Copy link
Contributor

target-bigquery provides the option to either denormalize into columns or leave as a single json column. That could be a useful feature for this target also.

target-bigquery docs:

Denormalized variants indicate data is unpacked during load with a resultant schema in BigQuery based on the tap schema. Non-denormalized means we have a fixed schema which loads all data into an unstructured JSON column. They are both useful patterns. The latter allowing BigQuery to work with schemaless or rapidly changing sources such as MongoDB instantly, while the former is more performant and convenient to start modeling quickly.

@DouweM
Copy link

DouweM commented Jul 28, 2023

@pnadolny13 I think this would be a great setting handled by the target SDK for any (database) destinations that support JSON objects!

@tayloramurphy
Copy link

@pnadolny13 or @edgarrmondragon do we have a relevant SDK issue for this? Would be good to get it in there.

We do have some interest from a prospect for this.

@edgarrmondragon
Copy link
Member

edgarrmondragon commented Jul 28, 2023

@pnadolny13 or @edgarrmondragon do we have a relevant SDK issue for this? Would be good to get it in there.

We do have some interest from a prospect for this.

@tayloramurphy I don't think there is one. I'm logging it.

@edgarrmondragon
Copy link
Member

edgarrmondragon commented Jul 28, 2023

@tayloramurphy I don't think there is one. I'm logging it.

See meltano/sdk#699 meltano/sdk#1883

@edgarrmondragon
Copy link
Member

@tayloramurphy I meant to link meltano/sdk#1883 😅

@tjvananne
Copy link

+1 for loading JSON data into variant fields. We have some deeply-nested JSON fields that we prefer to not flatten at load time.

This is how the transferwise variant of target-snowflake works today, but we're actively working on moving away from that variant (it sometimes isn't compatible with non-transferwise taps).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

5 participants