You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An option for dismiss_review's when that only triggers when commits are added to a PR's head, but not when it is rebased (in other words, only accounting for changes made on commits not on the target branch).
Why? We use approvals on A/B branches to indicate that they have been reviewed, before triggering a release, which then allows other tools to run the A/B test down the line. We then want the reviews to be dismissed if the PR is updated with new changes, but we still want the branch to keep being released and used when the main branch is updated, so that it stays up to date.
With approvals dismissed on rebase, it's necessary to manually reapprove. If approvals could be dismissed only on non-rebase changes, our model could be implemented.
Actual Behavior
Not possible at the moment. Rebases trigger dismiss_review.
Steps to Reproduce the Problem
Create config with dismiss_reviews and when set to either allowed value
Open a PR, approve it
Rebase the PR, notice approvals are gone
Specifications
Pull Request URL: ø
Mergify Config URL: ø
The text was updated successfully, but these errors were encountered:
Expected Behavior
An option for
dismiss_review
'swhen
that only triggers when commits are added to a PR's head, but not when it is rebased (in other words, only accounting for changes made on commits not on the target branch).Why? We use approvals on A/B branches to indicate that they have been reviewed, before triggering a release, which then allows other tools to run the A/B test down the line. We then want the reviews to be dismissed if the PR is updated with new changes, but we still want the branch to keep being released and used when the
main
branch is updated, so that it stays up to date.With approvals dismissed on rebase, it's necessary to manually reapprove. If approvals could be dismissed only on non-rebase changes, our model could be implemented.
Actual Behavior
Not possible at the moment. Rebases trigger
dismiss_review
.Steps to Reproduce the Problem
dismiss_reviews
andwhen
set to either allowed valueSpecifications
The text was updated successfully, but these errors were encountered: