Merge branch 'pyfive' of github.com:valeriupredoi/PyActiveStorage into pyfive

Author: Bryan Lawrence

.github/workflows/run-tests.yml

@@ -35,12 +35,12 @@ jobs:
           use-mamba: true
       - run: conda --version
       - run: python -V
-      - name: Install development version of bnlawrence/Pyfive:issue6
+      - name: Install development version of bnlawrence/Pyfive:issue60
         run: |
           cd ..
           git clone https://github.com/bnlawrence/pyfive.git
           cd pyfive
-          git checkout issue6
+          git checkout issue60
           pip install -e .
       - run: pip install -e .
       - run: pytest -n 2
@@ -66,12 +66,12 @@ jobs:
           use-mamba: true
       - run: conda --version
       - run: python -V
-      - name: Install development version of bnlawrence/Pyfive:issue6
+      - name: Install development version of bnlawrence/Pyfive:issue60
         run: |
           cd ..
           git clone https://github.com/bnlawrence/pyfive.git
           cd pyfive
-          git checkout issue6
+          git checkout issue60
           pip install -e .
       - run: pip install -e .
       - run: pytest

.github/workflows/test_s3_minio.yml

@@ -58,12 +58,12 @@ jobs:
           miniforge-version: "latest"
           miniforge-variant: Mambaforge
           use-mamba: true
-      - name: Install development version of bnlawrence/Pyfive:issue6
+      - name: Install development version of bnlawrence/Pyfive:issue60
         run: |
           cd ..
           git clone https://github.com/bnlawrence/pyfive.git
           cd pyfive
-          git checkout issue6
+          git checkout issue60
           pip install -e .
       - name: Install PyActiveStorage
         run: |

.github/workflows/test_s3_remote_reductionist.yml

@@ -53,12 +53,12 @@ jobs:
           miniforge-version: "latest"
           miniforge-variant: Mambaforge
           use-mamba: true
-      - name: Install development version of bnlawrence/Pyfive:issue6
+      - name: Install development version of bnlawrence/Pyfive:issue60
         run: |
           cd ..
           git clone https://github.com/bnlawrence/pyfive.git
           cd pyfive
-          git checkout issue6
+          git checkout issue60
           pip install -e .
       - name: Install PyActiveStorage
         run: |

tests/test_compression.py

@@ -16,9 +16,9 @@ def check_dataset_filters(temp_file: str, ncvar: str, compression: str, shuffle:
     # Sanity check that test data is compressed and filtered as expected.
     if USE_S3:
         with load_from_s3(temp_file) as test_data:
-            # NOTE: h5netcdf thinks zlib is gzip
-            assert test_data.variables[ncvar].compression == "gzip"
-            assert test_data.variables[ncvar].shuffle == shuffle
+            print("File attrs", test_data.attrs)
+            assert test_data[ncvar].compression == "gzip"
+            assert test_data[ncvar].shuffle == shuffle
     else:
         with Dataset(temp_file) as test_data:
             test_data_filters = test_data.variables[ncvar].filters()