Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: One Yocto deposit need even when account has sufficient available storage already #39

Open
jaswinder6991 opened this issue Jul 29, 2024 · 0 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@jaswinder6991
Copy link
Collaborator

Contact Details

No response

Version

1.0.1

What platform are you seeing the problem on?

Browser (Chrome)

Description

If you look at the calculateDepositStorage here, you will see that in a condition where account already has available storage more than needed for the current call, we attach 1 yocto deposit.

This is completely unnecessary and also breaks the flow for gas-only transaction.
In this case, use should not be directed to wallet page for signing as the app key can sign gas only transaction.
We should change this to 0 deposit and remove 1 yocto.

Steps To Reproduce

Try inputting same size data to Set function and see attached deposit as 1 instead of 0.

Expected Results

Attached deposit should be zero

Actual Results

Attached deposit is 1 yocto

Relevant console output

No response

@jaswinder6991 jaswinder6991 added the 🐛 bug Something isn't working label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants