Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if MAX_NUM_SOIL_TYPES is 15 then the Bushland simulation does not run correctly #38

Open
peterlafollette opened this issue Nov 4, 2024 · 0 comments

Comments

@peterlafollette
Copy link
Contributor

Minor issue where the LASAM simulation for Bushland doesn't run correctly. This is because MAX_NUM_SOIL_TYPES as defined in all.hxx was recently changed from 25 to 15, and Bushland uses soil types from a .dat file with more than 15 types. MAX_NUM_SOIL_TYPES has been reverted to 25 in the LGARTO branch, which fixes the issue. My opinion is that generally MAX_NUM_SOIL_TYPES should be greater than 15 in the event that a user wants to define a larger number of soil types, however I also see the reasoning for restricting MAX_NUM_SOIL_TYPES to be a smaller number.

Current behavior

Expected behavior

Steps to replicate behavior (include URLs)

Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant