Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only set maxrregcount when want to use less than 255 registers #2968

Merged
merged 2 commits into from
Sep 27, 2024
Merged

only set maxrregcount when want to use less than 255 registers #2968

merged 2 commits into from
Sep 27, 2024

Conversation

liqiangxl
Copy link
Collaborator

@liqiangxl liqiangxl commented Sep 19, 2024 •
edited
Loading

No actual perf change, A100, [H100]"http://nv/ek("
Why want to make this change?
See doc.

@liqiangxl
Copy link
Collaborator Author

!build --pybench

@jjsjann123 jjsjann123 self-requested a review September 24, 2024 20:33
jjsjann123
jjsjann123 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@jjsjann123 jjsjann123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use to explicitly set max_register to encourage register usage. But looks like it doesn't cause any regression for that use case any more.

Not opposing updating this.

@liqiangxl liqiangxl marked this pull request as ready for review September 26, 2024 12:37
@liqiangxl liqiangxl merged commit 9c009dd into main Sep 27, 2024
5 checks passed
@liqiangxl liqiangxl deleted the llu/max_reg_255 branch September 27, 2024 17:54
@naoyam
Copy link
Collaborator

naoyam commented Sep 28, 2024

Have you also run the diff check to see actual differences of register counts?

liqiangxl added a commit that referenced this pull request Sep 30, 2024
@liqiangxl
Revert "only set maxrregcount when want to use less than 255 registers (
29982d7 
#2968)"

This reverts commit 9c009dd.
@liqiangxl liqiangxl mentioned this pull request Sep 30, 2024
Closed
liqiangxl added a commit that referenced this pull request Sep 30, 2024
@liqiangxl
Revert "only set maxrregcount when want to use less than 255 registers (
0dd404e 
#2968)"

This reverts commit 9c009dd.
@liqiangxl liqiangxl mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjsjann123 jjsjann123 jjsjann123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liqiangxl @naoyam @jjsjann123