Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Align the character pruning vs sequence length based pruning for our models. #213

Open
VibhuJawa opened this issue Aug 20, 2024 · 0 comments
Open

[FEA] Align the character pruning vs sequence length based pruning for our models. #213

VibhuJawa opened this issue Aug 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@VibhuJawa
Copy link
Collaborator

VibhuJawa commented Aug 20, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

We need to align the character pruning vs sequence length based pruning for our models. We need to ensure our max_char defaults are lines up and only do it for models that have it built in while training

Additional context
#168 (comment)
@VibhuJawa VibhuJawa added the enhancement New feature or request label Aug 20, 2024
@VibhuJawa VibhuJawa mentioned this issue Aug 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VibhuJawa