Skip to content

Commit 247ac03

Browse files
Merge pull request #21 from NeowayLabs/add-commit-lint-exception
fix: Fix IsValidMessage method adding a new exception for merge from master to the branch.
2 parents 418fd90 + 0e8ce9d commit 247ac03

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
v2.0.2:
2+
- Fix IsValidMessage method adding a new exception for merge from master to the branch (@esequiel.virtuoso)
3+
14
v2.0.1:
25
- Fix IsValidMessage method to skip commit lint when the message is a merge from master to a developer branch. (@esequiel.virtuoso)
36
- Add chore option. (@esequiel.virtuoso)

src/commit-message/commit_message_manager.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ func isMergeMasterToBranch(message string) bool {
7979
splitedMessage := strings.Split(strings.ToLower(message), "\n")
8080

8181
for _, row := range splitedMessage {
82-
if strings.Contains(row, "'origin/master' into") {
82+
if strings.Contains(row, "'origin/master' into") || strings.Contains(row, "merge branch 'master' into") {
8383
return true
8484
}
8585
}

src/commit-message/commit_message_manager_test.go

+4
Original file line numberDiff line numberDiff line change
@@ -100,4 +100,8 @@ func TestIsValidMessageMergeMasterBranchSuccess(t *testing.T) {
100100
message := "first message row \n Merge remote-tracking branch 'origin/master' into something \n last message row"
101101
actual := f.commitMessageManager.IsValidMessage(message)
102102
tests.AssertTrue(t, actual)
103+
104+
message = "first message row \n Merge branch 'master' into something \n last message row"
105+
actual = f.commitMessageManager.IsValidMessage(message)
106+
tests.AssertTrue(t, actual)
103107
}

0 commit comments

Comments
 (0)