Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array syntax in RON dynamic collections? #78

Open
inodentry opened this issue Aug 4, 2022 · 1 comment · May be fixed by #151
Open

Array syntax in RON dynamic collections? #78

inodentry opened this issue Aug 4, 2022 · 1 comment · May be fixed by #151

Comments

@inodentry
Copy link
Contributor

Would it be possible to do something like this?

#[derive(AssetCollection)]
struct SpriteAnimationSequences {
    // maybe this needs a new attribute?
    // `collection(array)` or something,
    // to distinguish from `Files`
    #[asset(key = "anim.jumps", collection(typed)]
    jumps: Vec<Handle<TextureAtlas>>,
}
({
    // just use RON "array syntax"
    // to list as many items as we need
    "anim.jumps": [
        TextureAtlas (
            path: "jump_long.png",
            tile_size_x: 24.,
            tile_size_y: 32.,
            columns: 16,
            rows: 1,
        ),
        TextureAtlas (
            path: "jump_med.png",
            tile_size_x: 24.,
            tile_size_y: 32.,
            columns: 12,
            rows: 1,
        ),
        TextureAtlas (
            path: "jump_short.png",
            tile_size_x: 24.,
            tile_size_y: 32.,
            columns: 8,
            rows: 1,
        ),
    ],
})
@NiklasEi
Copy link
Owner

NiklasEi commented Aug 8, 2022

I thought this would be easily implemented using an untagged enum with a Single and a Vec variant. But I ran into ron-rs/ron#217.

NiklasEi added a commit that referenced this issue Aug 8, 2022
@NiklasEi
WIP: Support vectors of standard dynamic assets in dynamic asset file…
e9b5831 
…s (see #78)
NiklasEi added a commit that referenced this issue Sep 5, 2023
@NiklasEi
Allow collections of dynamic assets in the custom dynamic assets exam…
a5f75fa 
…ple (#78)
@NiklasEi NiklasEi linked a pull request Sep 10, 2023 that will close this issue
Draft
8 tasks
@NiklasEi NiklasEi mentioned this issue Feb 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support vectors of dynamic assets in dynamic asset files NiklasEi/bevy_asset_loader
2 participants
@NiklasEi @inodentry