Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting ImageAddressMode when loading images #235

Open
Amatsugu opened this issue Aug 1, 2024 · 0 comments · May be fixed by #238
Open

Add support for setting ImageAddressMode when loading images #235

Amatsugu opened this issue Aug 1, 2024 · 0 comments · May be fixed by #238

Comments

@Amatsugu
Copy link

Amatsugu commented Aug 1, 2024

It would be nice to have support for setting the address mode for textures loaded. Currently if a sampler is set, then all images are imported with default clamping behavior. I would like to be able to change this to Repeat during loading. Ideally there would be support for everything in ImageSamplerDescriptor, but I think the address mode is probably the most important for now.

pcwalton added a commit to pcwalton/bevy_asset_loader that referenced this issue Oct 14, 2024
This is a less ambitious version of NiklasEi#216 that should be ready to go. It
changes `#[image(sampler = linear)]` and `#[image(sampler = nearest)]`
to `#[image(sampler(filter = linear))]` and `#[image(sampler(filter =
nearest))]` respectively. The `sampler` list also supports `repeat` and
`clamp` modes. So, for example, you can write `#[image(sampler(filter =
linear, repeat)]` or `#[image(sampler(repeat))]`.

Closes NiklasEi#235.
@pcwalton pcwalton linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant