Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.nicegui: pattern setuptools does not match #383920

Open
3 tasks done
belamu opened this issue Feb 21, 2025 · 1 comment
Open
3 tasks done

python312Packages.nicegui: pattern setuptools does not match #383920

belamu opened this issue Feb 21, 2025 · 1 comment
Labels
0.kind: bug Something is broken

Comments

@belamu
Copy link

belamu commented Feb 21, 2025

Nixpkgs version

  • Unstable (25.05)

Describe the bug

When including python312Packages.nicegui, I get the error

error: builder for '/nix/store/iapscknypz8hjb3p74qa7wy5x77905l0-python3.12-nicegui-2.9.1.drv' failed with exit code 1;
       last 19 log lines:
...
       > Running phase: patchPhase
       > substituteStream() in derivation python3.12-nicegui-2.9.1: ERROR: pattern \"setuptools\>=30.3.0\,\<50\"\, doesn't match anything in file 'pyproject.toml'
       For full logs, run 'nix-store -l /nix/store/iapscknypz8hjb3p74qa7wy5x77905l0-python3.12-nicegui-2.9.1.drv'.
error: 1 dependencies of derivation '/nix/store/mb4a401r2xrnkd9faz77yksf11s0y8cl-python3-3.12.8-env.drv' failed to build

The error message is correct, since the code in nixpkgs is

  postPatch = ''
    substituteInPlace pyproject.toml \
      --replace-fail '"setuptools>=30.3.0,<50",' ""
  '';

while the interesting lines in the pyproject.toml are

[build-system]
requires = [
    "setuptools>=30.3.0",
    "poetry-core>=1.0.0"
]
build-backend = "poetry.core.masonry.api"

since a commit, that removed the <50

Steps to reproduce

shell.nix:

{ pkgs ? import <nixpkgs> {} }:
pkgs.mkShell {
    packages = with pkgs; [
      (python312.withPackages (python-pkgs: with python-pkgs; [
        nicegui
      ]))
    ];
  }

and run nix-shell while your update-channel is unstable

Expected behaviour

The package is built.

Screenshots

No response

Relevant log output

Additional context

I can create a merge request, but won't be able to in the next days.

System metadata

  • system: "x86_64-linux"
  • host os: Linux 6.12.14, NixOS, 25.05 (Warbler), 25.05beta755230.73cf49b8ad83
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.24.12
  • channels(root): "nixos"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Notify maintainers

@fabaff

Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

Is this issue important to you?

Add a 👍 reaction to issues you find important.

@belamu belamu added the 0.kind: bug Something is broken label Feb 21, 2025
@belamu
Copy link
Author

belamu commented Feb 21, 2025

When this is fixed, a version bump would also be possible.

belamu added a commit to belamu/nixpkgs that referenced this issue Feb 21, 2025
The postPatch phase creates an error, documented in NixOS#383920 due to a change in the pyproject.toml upstream.
This commit fits the replace string to the existing one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

1 participant