Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ugly error on bad password in keystore #6331

Open
kanej opened this issue Feb 18, 2025 · 0 comments · May be fixed by #6396
Open

Ugly error on bad password in keystore #6331

kanej opened this issue Feb 18, 2025 · 0 comments · May be fixed by #6396
Assignees
@kanej
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone
Public Alpha Feat...

Comments

@kanej
Copy link
Member

kanej commented Feb 18, 2025

currently, if the password is incorrect, the keystore decryption fails and throws an error. Should we handle this failure more gracefully?

Image

We should catch and throw a Hardhat specific error.
@kanej kanej added the v-next A Hardhat v3 development task label Feb 18, 2025
@kanej kanej added this to the Public Alpha milestone Feb 18, 2025
@kanej kanej added this to Hardhat Feb 18, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Feb 18, 2025
@kanej kanej moved this from Backlog to To-do in Hardhat Feb 18, 2025
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 18, 2025
@schaable schaable self-assigned this Feb 20, 2025
@schaable schaable moved this from To-do to In Progress in Hardhat Feb 20, 2025
@schaable schaable linked a pull request Feb 21, 2025 that will close this issue
Open
@schaable schaable assigned kanej and unassigned schaable Feb 21, 2025
@ChristopherDedominici ChristopherDedominici linked a pull request Feb 24, 2025 that will close this issue
Show hardhat error on bad password #6396
Open
@kanej kanej moved this from In Progress to In Review in Hardhat Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanej kanej

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Status: In Review
Milestone
Public Alpha Feature Rollout
Development

Successfully merging a pull request may close this issue.

Show hardhat error on bad password NomicFoundation/hardhat
2 participants
@kanej @schaable