Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignition mermaid diagram centering is broken for small deployments #6409

Open
zoeyTM opened this issue Feb 26, 2025 · 0 comments · May be fixed by #6410
Open

Ignition mermaid diagram centering is broken for small deployments #6409

zoeyTM opened this issue Feb 26, 2025 · 0 comments · May be fixed by #6410
Assignees
@zoeyTM
Milestone
Public Alpha Feat...

Comments

@zoeyTM
Copy link
Contributor

zoeyTM commented Feb 26, 2025 •
edited by kanej
Loading

If the module is small and simple enough, the visualization report is off center:

Image

We should center the mermaid diagram even for small modules, but ensure larger examples continue to work.
@zoeyTM zoeyTM self-assigned this Feb 26, 2025
@zoeyTM zoeyTM moved this to To-do in Hardhat Feb 26, 2025
@zoeyTM zoeyTM added this to Hardhat Feb 26, 2025
@zoeyTM zoeyTM moved this from To-do to In Progress in Hardhat Feb 26, 2025
@zoeyTM zoeyTM linked a pull request Feb 26, 2025 that will close this issue
Open
@zoeyTM zoeyTM moved this from In Progress to In Review in Hardhat Feb 26, 2025
@kanej kanej added this to the Public Alpha Feature Rollout milestone Feb 26, 2025
@zoeyTM zoeyTM mentioned this issue Feb 27, 2025
Merged
kanej pushed a commit that referenced this issue Feb 28, 2025
@zoeyTM
Merge pull request #6421 from NomicFoundation/fix/mermaid-centering-v3
af5eb2b 
Fix for mermaid centering on v3. Resolves #6409.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoeyTM zoeyTM

Labels
None yet
Projects
Hardhat
Status: In Review
Milestone
Public Alpha Feature Rollout
Development

Successfully merging a pull request may close this issue.

Override max-width to fix ignition graph centering NomicFoundation/hardhat
3 participants
@kanej @schaable @zoeyTM