Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.1: consistent style for field names and values in YAML comments #4331

Merged
merged 5 commits into from
Feb 16, 2025
Merged

3.1: consistent style for field names and values in YAML comments #4331

merged 5 commits into from
Feb 16, 2025

Conversation

ralfhandl
Copy link
Contributor

Fixes #4305

TDC decision: #4305 (comment)

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl ralfhandl marked this pull request as ready for review February 5, 2025 14:24
@ralfhandl ralfhandl requested review from a team as code owners February 5, 2025 14:24
@ralfhandl ralfhandl linked an issue Feb 5, 2025 that may be closed by this pull request
Define style for field names and values in YAML comments / $comment strings #4305
Open
@ralfhandl ralfhandl added the editorial Wording and stylistic issues label Feb 6, 2025
@ralfhandl ralfhandl mentioned this pull request Feb 6, 2025
Closed
mikekistler
mikekistler reviewed Feb 6, 2025
View reviewed changes
@ralfhandl @baywet
Update CONTRIBUTING.md
5d505db 
Co-authored-by: Vincent Biret <[email protected]>
ralfhandl
ralfhandl commented Feb 6, 2025
View reviewed changes
@ralfhandl ralfhandl requested review from baywet, mikekistler and a team and removed request for baywet February 6, 2025 20:58
ralfhandl
ralfhandl commented Feb 7, 2025
View reviewed changes
@ralfhandl ralfhandl requested a review from baywet February 7, 2025 10:22
mikekistler
mikekistler approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ralfhandl ralfhandl requested review from a team and removed request for baywet February 9, 2025 09:36
@ralfhandl ralfhandl mentioned this pull request Feb 14, 2025
Open
@ralfhandl ralfhandl merged commit ed39e4a into OAI:v3.1-dev Feb 16, 2025
2 checks passed
@ralfhandl ralfhandl deleted the v3.1-field-names-and-values-in-YAML-comments branch February 16, 2025 11:55
@ralfhandl ralfhandl mentioned this pull request Feb 20, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet left review comments

@handrews handrews handrews approved these changes

@mikekistler mikekistler mikekistler approved these changes

Assignees
No one assigned
Labels
editorial Wording and stylistic issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define style for field names and values in YAML comments / $comment strings
4 participants
@ralfhandl @handrews @baywet @mikekistler