[FIX] ERROR: null value in column location_id violates not-null constraint (#2)

Bhavesh Odedra · brian10048 · commit 06f3a88aea40 · 2021-04-22T16:33:36.000-04:00
diff --git a/fieldservice_sale/models/sale_order_line.py b/fieldservice_sale/models/sale_order_line.py
@@ -146,5 +146,6 @@ def _field_service_generation(self):
     def _prepare_invoice_line(self):
         res = super()._prepare_invoice_line()
         # by default: don't group fsm_orders on account.move.line
-        res.update({"fsm_order_ids": [(6, 0, [self.fsm_order_id.id])]})
+        if self.fsm_order_id:
+            res.update({"fsm_order_ids": [(6, 0, [self.fsm_order_id.id])]})
         return res
diff --git a/fieldservice_sale/readme/CONTRIBUTORS.rst b/fieldservice_sale/readme/CONTRIBUTORS.rst
@@ -4,6 +4,7 @@
   * Maxime Chambreuil <mchambreuil@opensourceintegrators.com>
   * Wolfgang Hall <whall@opensourceintegrators.com>
   * Raphael Lee <rlee@opensourceintegrators.com>
+  * Bhavesh Odedra <bodedra@opensourceintegrators.com>
 
 * Serpent Consulting Services Pvt. Ltd. <support@serpentcs.com>
 * Brian McMaster <brian@mcmpest.com>

-Original file line number
+Diff line change
   * Maxime Chambreuil <[email protected]>
   * Wolfgang Hall <[email protected]>
   * Raphael Lee <[email protected]>
 +  * Bhavesh Odedra <[email protected]>
 * Serpent Consulting Services Pvt. Ltd. <[email protected]>
 * Brian McMaster <[email protected]>