Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l10n_it_delivery_note: Sequenza emessa due volte e salto di numerazione #4596

Open
1 of 2 tasks
CiroBoxHub opened this issue Feb 3, 2025 · 5 comments · May be fixed by #4611
Open
1 of 2 tasks

l10n_it_delivery_note: Sequenza emessa due volte e salto di numerazione #4596

CiroBoxHub opened this issue Feb 3, 2025 · 5 comments · May be fixed by #4611
Labels
14.0 16.0 bug

Comments

@CiroBoxHub
Copy link
Contributor

CiroBoxHub commented Feb 3, 2025 •
edited by francesco-ooops
Loading

Con la modifica fatta su delivery note
a6126b8#diff-247a44a11e6c8f8060d6a49b458462a951d8e4e4f674c4af0786cbb3c403b84aR617
Il sistema fa passare due volte la funzione next_by_id() prendendo di fatto solo l'ultima numerazione emessa creando un salto di numerazione.
Di fatto il controllo è sempre True quindi viene emessa due volte la sequenza

Module

l10n_it_delivery_note

To Reproduce

Affected versions:

Steps to reproduce the behavior:

  1. Creazione nuovo ddt
  2. Validazione
  3. Salto di sequenza
@CiroBoxHub CiroBoxHub added the bug label Feb 3, 2025
@francesco-ooops
Copy link
Contributor

Riscontrato anche su v14

This was referenced Feb 5, 2025
Open
Open
This was linked to pull requests Feb 5, 2025
[14.0][IMP] l10n_it_delivery_note: better handling for _action_confirm #4599
Open
[16.0][IMP] l10n_it_delivery_note: better handling for _action_confirm #4601
Open
@francesco-ooops
Copy link
Contributor

@CiroBoxHub puoi fare review alle PR?

@aleuffre aleuffre linked a pull request Feb 10, 2025 that will close this issue
Open
@francesco-ooops francesco-ooops linked a pull request Feb 10, 2025 that will close this issue
[16.0][FIX] l10n_it_delivery_note: do not generate DN number twice #4611
Open
@CiroBoxHub
Copy link
Contributor Author

Fatto review sulla PR per la 16.0

@francesco-ooops
Copy link
Contributor

@CiroBoxHub dopo aver fatto una verifica, il fix da applicare è quello nella PR #4611 (anche se al momento i test sono rotti)

This was unlinked from pull requests Feb 13, 2025
[14.0][IMP] l10n_it_delivery_note: better handling for _action_confirm #4599
Open
[16.0][IMP] l10n_it_delivery_note: better handling for _action_confirm #4601
Open
@CiroBoxHub
Copy link
Contributor Author

fatto review anche su quella.
Quando sarà possibile mergiarla?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
14.0 16.0 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[16.0][FIX] l10n_it_delivery_note: do not generate DN number twice PyTech-SRL/l10n-italy
2 participants
@CiroBoxHub @francesco-ooops