[16.0][MIG] base_tier_validation_correction

Author: ChrisOForgeFlow

base_tier_validation_correction/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Base Tier Validation Correction",
     "summary": "Correct tier.review data after it has been created.",
-    "version": "14.0.1.0.1",
+    "version": "16.0.1.0.0",
     "category": "Tools",
     "website": "https://github.com/OCA/server-ux",
     "author": "Ecosoft,Odoo Community Association (OCA)",

base_tier_validation_correction/models/tier_correction.py

@@ -38,7 +38,6 @@ class TierCorrection(models.Model):
         selection=[
             ("reviewer", "Reassign Reviewer(s)"),
         ],
-        string="Correction Type",
         default="reviewer",
         required=True,
         readonly=True,
@@ -274,15 +273,25 @@ def _notify_reviewer_change(self, ttype="correct"):
             reviewers = ", ".join(
                 tier_reviews.reviewer_ids.filtered("name").mapped("name")
             )
-            message = _("The Correction '%s', corrrected reviewers on '%s' to '%s'") % (
-                self.correction_id.name,
-                reviews,
-                reviewers,
-            )
+            message = _(
+                "The Correction '%(name)s', "
+                "corrrected reviewers "
+                "on '%(reviews)s' to '%(reviewers)s'"
+            ) % {
+                "name": self.correction_id.name,
+                "reviews": reviews,
+                "reviewers": reviewers,
+            }
             if ttype == "revert":
                 message = _(
-                    "The Correction '%s', reverted reviewers on '%s' back to '%s'"
-                ) % (self.correction_id.name, reviews, reviewers)
+                    "The Correction '%(name)s', "
+                    "reverted reviewers on '%(reviews)s' "
+                    "back to '%(reviewers)s'"
+                ) % {
+                    "name": self.correction_id.name,
+                    "reviews": reviews,
+                    "reviewers": reviewers,
+                }
             getattr(self.resource_ref.sudo(), post)(
                 subtype_xmlid=(
                     "base_tier_validation_correction.mt_tier_validation_correction"

base_tier_validation_correction/security/correction_groups.xml

@@ -1,15 +1,13 @@
 <?xml version="1.0" encoding="utf-8" ?>
-<odoo>
-<data noupdate="0">
+<odoo noupdate="0">
 
     <record id="group_tier_correction" model="res.groups">
         <field name="name">Tier Review Correction</field>
         <field name="category_id" ref="base.module_category_hidden" />
         <field
-                name="users"
-                eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"
-            />
+            name="users"
+            eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"
+        />
     </record>
 
-</data>
 </odoo>

base_tier_validation_correction/tests/test_tier_validation.py

@@ -13,7 +13,7 @@
 class TierTierValidation(CommonTierValidation):
     def test_01_tier_correction(self):
         """With the document in validation,
-        - User click on Change Reivewer to creat new correction
+        - User click on Change Reviewer to creat new correction
         - Change the reviewer to user 2, test that user 2 need_validation
         - Revert to user 1, test that now user 1 need validation
         - Click on Change Review link from the document again, then view the corrections
@@ -24,11 +24,11 @@ def test_01_tier_correction(self):
         self.assertFalse(doc_user2.can_review)
         # User 1, is the reviewer as specified in the tier.definition
         doc_user1 = self.test_record.with_user(self.test_user_1.id)
-        doc_user1.invalidate_cache()
+        doc_user1.invalidate_recordset()
         self.assertTrue(doc_user1.can_review)
         # Change Reviewer from user 1 -> user 2
         ctx = {"active_id": doc_user1.id, "active_model": doc_user1._name}
-        res = doc_user1.with_context(ctx).view_tier_correction()
+        res = doc_user1.with_context(**ctx).view_tier_correction()
         self.assertFalse(res["domain"])  # No existing correction, create new
         correction = self.env["tier.correction"].create(
             {
@@ -66,23 +66,23 @@ def test_01_tier_correction(self):
         self.assertTrue(reviews)
         # Make correction, now user 2 can review
         correction.action_done()
-        doc_user2.invalidate_cache()
+        doc_user2.invalidate_recordset()
         self.assertTrue(doc_user2.can_review)
-        doc_user1.invalidate_cache()
+        doc_user1.invalidate_recordset()
         self.assertFalse(doc_user1.can_review)
-        # Make reversion, now user 1 can reivew
+        # Make reversion, now user 1 can review
         correction.action_revert()
-        doc_user1.invalidate_cache()
+        doc_user1.invalidate_recordset()
         self.assertTrue(doc_user1.can_review)
-        doc_user2.invalidate_cache()
+        doc_user2.invalidate_recordset()
         self.assertFalse(doc_user2.can_review)
         # From the document, view tier correction once again
-        res = doc_user1.with_context(ctx).view_tier_correction()
+        res = doc_user1.with_context(**ctx).view_tier_correction()
         self.assertEqual(res["domain"][0][2], [correction.id])
 
     def test_01_tier_correction_by_scheduler(self):
         """With the document in validation,
-        - User click on Change Reivewer to creat new correction
+        - User click on Change Reviewer to creat new correction
         - Setup Scheduled Correction Date and Scheduled Revert, test date constraints
         - Run scheduler which change reviewer to user 2, test user 2 need_validation
         - Run scheduler which revert to user 1, test user 1 need validation
@@ -93,11 +93,11 @@ def test_01_tier_correction_by_scheduler(self):
         self.assertFalse(doc_user2.can_review)
         # User 1, is the reviewer as specified in the tier.definition
         doc_user1 = self.test_record.with_user(self.test_user_1.id)
-        doc_user1.invalidate_cache()
+        doc_user1.invalidate_recordset()
         self.assertTrue(doc_user1.can_review)
         # Change Reviewer from user 1 -> user 2
         ctx = {"active_id": doc_user1.id, "active_model": doc_user1._name}
-        res = doc_user1.with_context(ctx).view_tier_correction()
+        res = doc_user1.with_context(**ctx).view_tier_correction()
         self.assertFalse(res["domain"])  # No existing correction, create new
         correction = self.env["tier.correction"].create(
             {
@@ -116,9 +116,9 @@ def test_01_tier_correction_by_scheduler(self):
         correction.action_prepare()
         self.assertEqual(correction.state, "prepare")
         scheduler.method_direct_trigger()
-        doc_user2.invalidate_cache()
+        doc_user2.invalidate_recordset()
         self.assertTrue(doc_user2.can_review)
-        doc_user1.invalidate_cache()
+        doc_user1.invalidate_recordset()
         self.assertFalse(doc_user1.can_review)
         # Run Schedulder, to revert
         with self.assertRaises(ValidationError):
@@ -129,7 +129,7 @@ def test_01_tier_correction_by_scheduler(self):
         )
         self.assertEqual(correction.state, "done")
         scheduler.method_direct_trigger()
-        doc_user2.invalidate_cache()
+        doc_user2.invalidate_recordset()
         self.assertTrue(doc_user1.can_review)
-        doc_user1.invalidate_cache()
+        doc_user1.invalidate_recordset()
         self.assertFalse(doc_user2.can_review)

base_tier_validation_correction/views/tier_correction_view.xml

@@ -6,7 +6,7 @@
         <field name="name">tier.correction.tree</field>
         <field name="model">tier.correction</field>
         <field name="arch" type="xml">
-            <tree string="Tier Correction">
+            <tree>
                 <field name="name" />
                 <field name="correction_type" />
                 <field name="reference" />