Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve names of variables #28

Open
JordiBolibar opened this issue Sep 7, 2023 · 0 comments
Open

Improve names of variables #28

JordiBolibar opened this issue Sep 7, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@JordiBolibar
Copy link
Member

After starting the creation of some examples for Huginn, I'm realizing that some variable names might be confusing. The following should be updated:

For SimulationParameters:

  • velocities should be changed to download_velocities, in order to make it clearer that it controls the download of the large ice velocity files (which are skipped during CI).
  • working_dir should be renamed or changed, since there is a variable with the same name in OGGMParameters.

I will update this list if I come up with more.
@JordiBolibar JordiBolibar added the enhancement New feature or request label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JordiBolibar