Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Release 0.11 Pre-Production test checklist #454

Closed
7 tasks done
aufdenkampe opened this issue Jan 16, 2020 · 16 comments
Closed
7 tasks done

Pre-Release 0.11 Pre-Production test checklist #454

aufdenkampe opened this issue Jan 16, 2020 · 16 comments

Comments

@aufdenkampe
Copy link
Member

aufdenkampe commented Jan 16, 2020

Pre-Production = staging web server + production database server

Just prior to release, we will point the staging web server to the production database server.

AFTER we do this, we will do a 2nd round of testing, which will include a general set of tests and release-specific tests.

General Tests, confirming the the following work:

Release-Specific Tests

Checklist copied from #419

@aufdenkampe aufdenkampe changed the title Pre-Release 0.11 testing of Pre-Production Pre-Release 0.11 test checklist for Pre-Production Jan 16, 2020
@aufdenkampe aufdenkampe changed the title Pre-Release 0.11 test checklist for Pre-Production Pre-Release 0.11 pre-Production test checklist Jan 16, 2020
@aufdenkampe aufdenkampe changed the title Pre-Release 0.11 pre-Production test checklist Pre-Release 0.11 Pre-Production test checklist Jan 16, 2020
@HeatherBrooks
Copy link
Collaborator

@aufdenkampe Not in your checklist above, but I registered a new site and created a leaf pack experiment. Things look good except the title and legend are missing from the second chart. Also, when I tried to download a CSV of the data I got "Server Error (500)", not sure if that's expected at this stage?

https://staging.monitormywatershed.org/sites/WCC_US1/leafpack/27/

@aufdenkampe
Copy link
Member Author

aufdenkampe commented Jan 22, 2020

@HeatherBrooks, thanks for doing a release-specific test. I don't think either error should occur.

@htaolimno, can you look into these two issues, which I don't think should be occurring:

  • Missing title and legend for second chart of a new Leaf Pack experiment
  • Get a "Server Error (500)" when downloading a CSV

@htaolimno
Copy link
Collaborator

@HeatherBrooks csv download still calls the old Biotic Index calculation and that caused error. I'll fix that. I'll also look into the other issue - have to figure out why occurs on production database.

htaolimno added a commit that referenced this issue Jan 22, 2020
replace old biotic index by new "pollution Tolerance Index" #454
@htaolimno
Copy link
Collaborator

@HeatherBrooks fixed broken csv download.

@HeatherBrooks
Copy link
Collaborator

@htaolimno Thanks for fixing the csv download.

Just to clarify, in Anthony's checklist above "Missing title and legend for second chart of a new Leaf Pack experiment" you can remove the word "new" as the title and legend don't appear on pre-existing experiments either. See https://staging.monitormywatershed.org/sites/BogBrook_Rt312/leafpack/4/

@htaolimno
Copy link
Collaborator

@HeatherBrooks : seems that an older version of barchart.js file is used and that caused missing title and legend on the chart. Let me check a few things.

@htaolimno
Copy link
Collaborator

htaolimno commented Jan 22, 2020

@HeatherBrooks Think I figured it out - I should have run "collectstatic" command to collect static files on the server and that's why the latest version of barchart.js was not picked up. You probably need to clear the browser cache or open the page in private mode to see immediate change.

@HeatherBrooks
Copy link
Collaborator

@htaolimno Yep, the title and legend are back. Thanks!

@aufdenkampe
Copy link
Member Author

@htaolimno, thanks for figuring this out. Please add the "run collectstatic command" to our workflow documentation wiki.

All, does everything else check out?

@dbressler75
Copy link
Collaborator

@aufdenkampe, it looks great! I tested first three bullets and all worked well. Also tested various other things, downloading from panels, main download tabs, plotting in tsa. The tsa x axis zooming and y axis dragging and zooming work much nicer now!

I apologize for the last minute questions and I'm guessing these are fixes for later but here are a few things: 1) is the size of csv files that can be uploaded going to be increased? (currently it's ~1wk or data) 2) is there a way to show/confirm when files are being downloaded 3) tsa y axis inputting axis range? (i.e., same as that option for x axis). Thanks Anthony!

@aufdenkampe
Copy link
Member Author

@dbressler75, thanks for that testing! I'm glad to hear things are working well for you.

Unfortunately, there were a number of issues in our Release 0.11 - Leaf Pack update + minor features & fixes milestone that we needed to postpone to future work, including the CSV-related issues #430, #443, etc.

Fortunately, the ability to modify the TSA x-axis and y-axis ranges has been working for a long time (since Aug. 2018, see #236). Do it by hovering your pointer over the axis and dragging to shift the axis and wheel-scrolling (or two finger trackpad swiping) to resize the axis. For details, read #236 (comment).

@aufdenkampe
Copy link
Member Author

@tslawecki, we are ready for Release 0.11 to production tomorrow morning!

@dbressler75
Copy link
Collaborator

dbressler75 commented Jan 23, 2020 via email

@aufdenkampe
Copy link
Member Author

@dbressler75, thanks for explaining.

Adding an exact Y-axis min/max data entry option isn't a feature that was ever on my/our radar.

Could you create a new issue describing your request for this feature? Our approach to developing this portal is that we work on things that are described in issues, to avoid missing requests like this one that we hadn't heard.

@dbressler75
Copy link
Collaborator

dbressler75 commented Jan 23, 2020 via email

@aufdenkampe
Copy link
Member Author

@dbressler75, thanks for creating the new issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants