Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow setting of UID and GID #708

Open
alexanderwiller opened this issue Feb 2, 2024 · 2 comments
Open

Feature request: Allow setting of UID and GID #708

alexanderwiller opened this issue Feb 2, 2024 · 2 comments
Labels
feature request Issues that request new features to be added to OnlyOffice

Comments

@alexanderwiller
Copy link

alexanderwiller commented Feb 2, 2024

Feature request

Allow setting of UID and GID used by the container.

By implementing this, when bind mounts are used, users are not forced to allocate the containers fixed UID/GIDs to Onlyoffice on the host system as well.

What is the current behavior?

UID 109 and GID 111 are used by the container and cannot be changed easily.

What is the expected behavior?

UID and GID can be set to custom values, e.g. by environment variables PUID and PGID, e.g. as with linuxserver.io images: https://github.com/linuxserver/docker-mariadb?tab=readme-ov-file#docker-compose-recommended-click-here-for-more-info

See also: #40 (comment)

DocumentServer Docker tag:
latest, but all versions should be affected.

Host Operating System:
Ubuntu 22.04 LTS

@alexanderwiller
Copy link
Author

alexanderwiller commented Feb 2, 2024

After further investigation, I see that a number of users and groups are present in the DocumentServer container:

redis:x:106:108::/var/lib/redis:/usr/sbin/nologin
postgres:x:107:109:PostgreSQL administrator,,,:/var/lib/postgresql:/bin/bash
rabbitmq:x:108:110:RabbitMQ messaging server,,,:/var/lib/rabbitmq:/usr/sbin/nologin

This makes me wonder, is it practical to allow setting all these IDs to custom values by means of some mechanism (e.g said env variables), or should I just use docker volumes that at least provide some level of UID/GID isolation, given that the files are not accessible by the host directly?

No matter what, I think it would be beneficial to allow mapping all services inside of the container to UIDs and GIDs that are not in use on the host by any other service.

@igwyd
Copy link
Member

igwyd commented Feb 16, 2024

Hello @alexanderwiller, sorry for the late reply. Thank for detaled report, I created ticket #66520 with your proposal.

@Rita-Bubnova Rita-Bubnova added the feature request Issues that request new features to be added to OnlyOffice label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to OnlyOffice
Projects
None yet
Development

No branches or pull requests

3 participants