Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up console of warnings and errors #1197

Merged
merged 3 commits into from
Feb 13, 2025
Merged

clean up console of warnings and errors #1197

merged 3 commits into from
Feb 13, 2025

Conversation

jgadsden
Copy link
Collaborator

@jgadsden jgadsden commented Feb 10, 2025

Summary:
Provides passive events support to touchstart and mousewheel events in the diagram, which prevents the warnings :

  • "Added non-passive event listener to a scroll-blocking 'mousewheel' event."
  • "Added non-passive event listener to a scroll-blocking 'touchstart' event."

also removes client webSocketURL from Vue devServer config due to error on the console for the desktop app:

  • "WebSocket connection to 'wss://localhost/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED"

Description for the changelog:
clean up console of warnings and errors

Other info:
closes #1100

@jgadsden jgadsden self-assigned this Feb 10, 2025
@jgadsden jgadsden marked this pull request as draft February 10, 2025 21:48
@jgadsden jgadsden added bug Something isn't working version-2.4 labels Feb 10, 2025
@@ -30,13 +30,7 @@ const devServerConfig = hasTlsCredentials
allowedHosts: [appHostname],
}
: {
client: {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericfitz and @lreading , is this OK to remove? It was the cause of console errors for the desktop app - but seems a bit brutal of me just to delete it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's fine to delete, unless @ericfitz disagrees! :)

@jgadsden jgadsden marked this pull request as ready for review February 12, 2025 13:57
@jgadsden jgadsden merged commit 49d378d into main Feb 13, 2025
10 checks passed
@jgadsden jgadsden deleted the non-passive-event branch February 13, 2025 09:46
@ericfitz
Copy link
Collaborator

Sorry I just saw this, this doesn't break anything that I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version-2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Added non-passive event listener to a scroll-blocking event
3 participants