Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's missing? #12

Open
sayedihashimi opened this issue Apr 4, 2015 · 11 comments
Open

What's missing? #12

sayedihashimi opened this issue Apr 4, 2015 · 11 comments
Labels

Comments

@sayedihashimi
Copy link
Member

We recently got started on this project and for the initial release we are thinking to have the following content below.

Generators (project templates)

  • Class library
  • Portable class library
  • Console app
  • xUnit test project

Sub-generators (item templates)

  • New Class
  • New Interface
  • app.config
  • AssemblyInfo.cs
  • Resource file
  • xUnit test case

I'd like to find out what you think is missing here and how we can make this better.

@ciwchris
Copy link

ciwchris commented Apr 6, 2015

Is it possible to detect or be able to specify the version of the .net framework being targeted and if it's .net 5 then use the new project structure? Or should a new generator be created for .net 5 projects?

@sayedihashimi
Copy link
Member Author

@ciwchris thanks for the reply.

VS telemetry tells us that most people pick the latest framework to target. Also it's easy to modify the target Fx after creating the project. You just edit the <TargetFramework> element in the .csproj file.

That being said we could consider a --fx switch which could set this. This is similar to the --gulp option available in the asp.net 5 yo generators.

Thoughts?

@shmuelie
Copy link
Contributor

shmuelie commented Apr 6, 2015

I'm liking @sayedihashimi 's idea about having a --fx- flag.

@sayedihashimi
Copy link
Member Author

I created #14. I'm supportive of it.

@ciwchris
Copy link

ciwchris commented Apr 7, 2015

I was hoping to not use .csproj files and instead have projects created similar to the sample console app when using .net5. Could the default be no .csproj files but if an older version is specified using the --fx flag then .csproj files would be used?

@shmuelie
Copy link
Contributor

shmuelie commented Apr 7, 2015

Unless I'm misunderstanding something the new JSON based project files are only for ASP.NET, or are they for all .NET vNext?

@davidfowl
Copy link
Member

@ciwchris I like that idea 😄

@SamuelEnglard The new JSON based project files can be used to build any project type (build not run). It's a project system that supports cross compilation and producing nuget packages out of the box.

@shmuelie
Copy link
Contributor

shmuelie commented Apr 7, 2015

So is JSON replacing *proj files? If so then clearly when targeting latest we should use it. If not we might need another flag, though I'd make the default JSON still for newest

@sayedihashimi
Copy link
Member Author

I was hoping to not use .csproj files and instead have projects created similar to the sample console app when using .net5.

As Fowler mentioned you would use generator-aspnet in that case. I just posted a wiki on the goals of generator-aspnet and how we are recommending for others to create related generators https://github.com/OmniSharp/generator-aspnet/wiki/goals-and-related-generators.

So is JSON replacing *proj files?

No (or at least not yet). If they do then we will adapt this generator as well as generator-aspnet to align with whatever Visual Studio ships.

shmuelie added a commit to shmuelie/generator-csharp that referenced this issue Apr 7, 2015
@ciwchris
Copy link

ciwchris commented Apr 7, 2015

Thank you for the clarification, I did not realize there was a new console application under aspnet, that was unexpected.

@davidfowl
Copy link
Member

We're in the process of refining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants