Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag skipDefaultUserAgent to skip setting user agent in TypeScrip… #20611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christophmohr
Copy link

@christophmohr christophmohr commented Feb 7, 2025

closes #20600

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha

@macjohnny
Copy link
Member

@christophmohr would it be possible to just set httpUserAgent=""?

@christophmohr
Copy link
Author

@macjohnny Do you have in mind to drop the flag entirely and just set an empty User-Agent-header resp. remove it?

I've just followed the solution of #20367 suggested by @wing328

@macjohnny
Copy link
Member

yes, setting an empty user agent should work here, so no additional flag would be needed, right?

we recently had #20067 and #20571

@christophmohr
Copy link
Author

I'm not quite sure if I get you right, @macjohnny - but setting the httpUserAgent within the config has no effect.

image

I'm still getting the Refused to set unsafe header "User-Agent" error within Chrome

Or do you mean adjusting the code within the mustache-file and setting the User-Agent to '' like

{{#httpUserAgent}} 'User-Agent': "", {{/httpUserAgent}}

@macjohnny
Copy link
Member

are you using the latest snapshot release?

@macjohnny
Copy link
Member

#20571 was merged only recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Add skipDefaultUserAgent to typescript-axios-generator
2 participants