Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to describe interrupted timeseries #44

Closed
christian-rli opened this issue Dec 7, 2020 · 4 comments
Closed

Not possible to describe interrupted timeseries #44

christian-rli opened this issue Dec 7, 2020 · 4 comments
Assignees
Labels
other: help wanted 🙋 Extra attention is needed type: enhancement ⚙️ Improvement of an existing feature type: question ❓ Further information is requested

Comments

@christian-rli
Copy link
Contributor

As was noted in a table in review OpenEnergyPlatform/data-preprocessing#75 it is not possible to make a detailed description of gaps in timeseries. In the original issue, a table with data from 2030 and 2050 and no data in between needed a start and end value for the timeseries. Techincally, it would have been possible to create two tables and be done with it, which also seems more correct. However this would ignore the larger issue. All kinds of gaps may occur due to problems in the creation. It's not a feasible approach to break apart tables after every little gap.

When a long timeseries misses, say, a month, there are several options that I see:

  1. Ignore gaps in the metadata and set the first date as start and the last date as end.
  2. Create a new table after every gap
  3. Find a way to mention the gaps in the metadata in a newer version
  4. Find a compromise solution where e.g. there are tables for every year and gaps within can be ignored but for timeseries with a year or longer gap, require yearly tables

This should be discussed for the next standard.

(In the original issue, we opted for solution 1)

@christian-rli
Copy link
Contributor Author

Also see the issue in the ontology related to timeseries: OpenEnergyPlatform/ontology#267

@Ludee Ludee added type: enhancement ⚙️ Improvement of an existing feature other: help wanted 🙋 Extra attention is needed type: question ❓ Further information is requested v1.5 labels Jan 18, 2021
@chrwm
Copy link
Member

chrwm commented Aug 25, 2021

+1 the issue is still relevant. It's not possible to annotate data that stem from separate years. e.g. 2020, 2030, 2040

@chrwm
Copy link
Member

chrwm commented Oct 14, 2021

What about changing the value of the timeseries key to a list of dicts with its current subkeys.
It could be implemented like this:

"temporal": {
        "referenceDate": "2016-01-01",
        "timeseries": [{
            "start": "2016-01-01T00:00+01",
            "end": "2016-12-31T23:00+01",
            "resolution": "1 h",
            "alignment": "left",
            "aggregationType": "sum"
        }, 
        {
            "start": "2018-01-01T00:00+01",
            "end": "2019-12-31T23:00+01",
            "resolution": "1 h",
            "alignment": "left",
            "aggregationType": "sum"
        }]

This way multiple time periods (values) can be entered for the timeseries key and the flexibility for their specification remains.
@christian-rli could this implementation work?

chrwm added a commit that referenced this issue Oct 22, 2021
The adaption refers to #44. The key 10.2 timeseries is changed to a list of dictionaries. This way multiple timeseries, gaps in timeseries and multiple years can be described.
@chrwm
Copy link
Member

chrwm commented Oct 22, 2021

The change has been implemented in v1.5.0 as described above.

@chrwm chrwm closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other: help wanted 🙋 Extra attention is needed type: enhancement ⚙️ Improvement of an existing feature type: question ❓ Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants