Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev mode slowdown with high CPU usage on Windows & Intel Mac with project with large number of files #1709

Open
scottkurz opened this issue Jul 24, 2023 · 3 comments
Labels

Comments

@scottkurz
Copy link
Member

scottkurz commented Jul 24, 2023

Though I don't have a public recreate yet, I have an internal report of dev mode slowdown with a project with a large number ~7K Java source files.

Tools like process explorer show high CPU usage and the overall system becomes unresponsive and slow.

Have experienced this with both Semeru and Temurin Java 17 JDKs

One idea to consider: could it make sense, e.g. in a Liberty Tools IDE use case, to take advantage of the fact that the IDE is already watching for certain file changes and doing builds upon detection (e.g. javac upon .java file changes) and do have a "lighter" dev mode which, say, doesn't bother to watch for Java changes?

What about something like filtered web resources? I'm not sure if, in Eclipse, for example, the m2e integration would do call the appropriate mvn goal if a filtered web resource were detected.

We need to start by profiling and understanding where the performance slowdown is coming from in more detail.

@scottkurz scottkurz moved this to To Discuss in Liberty Tools Release Plan Jul 24, 2023
@scottkurz scottkurz moved this from To Discuss to Target feature release in Liberty Tools Release Plan Jul 25, 2023
@scottkurz
Copy link
Member Author

2023-11-15 DXDI UPDATE:

Received data from internal users; HC data shows large amt of time in compile.

  • Re-up the idea of doing an "IDE mode" variant of dev mode... maybe avoid watching and compiling Java parts assuming they're going to be handled by the IDE
  • Concerns?
    • What does this do to the generateFeatures logic? (which runs in a loop) Can it watch .class files and not .java source?
    • Are there any other cases where we were looking at .java to influence dev/build logic, and not just compiling the Java?
    • What about "recompileDependencies" config? The default value is false when running dev mode on a single module, and true when running dev mode on a multi module project. What do the IDEs do analogously? (Is it configurable?)
  • TODO: start by doing a prototype (prioritize at some point)
  • Alternate idea: is there a more efficient way to do multi-module compilation specifically, but still basically have dev mode watch & compile like it's doing?

@scottkurz
Copy link
Member Author

Adding another idea: what if we were to introduce a behavior of only compiling Java files if they are newer than the classes?

And perhaps this would be too complicated to compute.... if every BB.java is newer than the corresponding BB.class I still might need to recompile BB if its dependency AA has been updated.

But say every .class file were newer than every .java file? Then we wouldn't need to compile in that circumstance, right? Could this actually be typical enough to make a difference? Might this only work with a larger compileWait parm setting (than the dflt .5s)?

Something to consider as we prototype?

@scottkurz
Copy link
Member Author

Are there any "correctness" concerns here? Is there any type of race condition such that for classes A and B, with A dependent on B, the pair could be compiled such that the A.class file in target/classes ends up having been compiled against the old version of B?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To Discuss
Development

No branches or pull requests

1 participant