Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add a feature to make it possible so select and copy text in grid without trigger click event in Admin grid. #4666

Open
1 task done
JesperHerrloff opened this issue Mar 6, 2025 · 2 comments
Labels
new feature review needed Problem should be verified

Comments

@JesperHerrloff
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

Would it be of interest to implement said solution? Only one file is affected and will fix the issue in every admin grid.

I can make a pull request if there is interest in the solution? Its only a conditional check in js/mage/adminhtml/grid.js to fix this permanently.

Expected Behavior

Be able to select for example sku in admin grid for products or order incrementId in order grid.

A selection should not trigger click.

Benefits

I think this will benefit all ecommerce users, as they will be able to select for example a sku in backend copy it then search it in frontend to verify it is searchable.

I think it will not do any harm to anyone.

Anything else?

This is a fix I do every release. :) It would be nice to make this into the framework.

@JesperHerrloff JesperHerrloff added new feature review needed Problem should be verified labels Mar 6, 2025
@kiatng
Copy link
Contributor

kiatng commented Mar 6, 2025

See PR #4029

@sreichel
Copy link
Contributor

sreichel commented Mar 9, 2025

@kiatng do you have some minutes to write a short docunentation (doc blog-post?)

Not tested, but is it possible to make columns copyable via xml or observer?

(something for #3451 ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature review needed Problem should be verified
Projects
None yet
Development

No branches or pull requests

3 participants