Skip to content

Commit a9ec269

Browse files
committed
[Android] Drop i686 as a build target
I don't believe i686 phones ever existed, and emulators should prefer x86_64 instead.
1 parent d941cc4 commit a9ec269

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

android-build.sh

+5-6
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ set -x
2525
LDK_C_BINDINGS="$(realpath $2)"
2626
RUST_LIGHTNING="$(realpath $1)"
2727
pushd "$2"
28-
export LDK_C_BINDINGS_EXTRA_TARGETS="x86_64-linux-android i686-linux-android armv7-linux-androideabi aarch64-linux-android"
29-
export LDK_C_BINDINGS_EXTRA_TARGET_CCS="x86_64-linux-android24-clang i686-linux-android24-clang armv7a-linux-androideabi24-clang aarch64-linux-android24-clang"
28+
export LDK_C_BINDINGS_EXTRA_TARGETS="x86_64-linux-android armv7-linux-androideabi aarch64-linux-android"
29+
export LDK_C_BINDINGS_EXTRA_TARGET_CCS="x86_64-linux-android24-clang armv7a-linux-androideabi24-clang aarch64-linux-android24-clang"
3030
./genbindings.sh "$RUST_LIGHTNING" true
3131
popd
3232

@@ -38,8 +38,8 @@ rm -fr src/main/resources
3838

3939
EXTRA_TARGETS=( $LDK_C_BINDINGS_EXTRA_TARGETS )
4040
EXTRA_TARGET_CCS=( $LDK_C_BINDINGS_EXTRA_TARGET_CCS )
41-
TARGET_CPUS=( "sandybridge" "generic" "generic" "generic" )
42-
STRIPS=( "x86_64-linux-android-strip" "i686-linux-android-strip" "arm-linux-androideabi-strip" "aarch64-linux-android-strip" )
41+
TARGET_CPUS=( "sandybridge" "generic" "generic" )
42+
STRIPS=( "x86_64-linux-android-strip" "arm-linux-androideabi-strip" "aarch64-linux-android-strip" )
4343
for IDX in ${!EXTRA_TARGETS[@]}; do
4444
export CC="${EXTRA_TARGET_CCS[$IDX]}"
4545
export LDK_TARGET="${EXTRA_TARGETS[$IDX]}"
@@ -57,11 +57,10 @@ ls ldk-java-classes.jar
5757
rm -rf aar
5858
mkdir aar
5959
cp -r "$3/"* ./aar/
60-
mkdir -p ./aar/jni/{armeabi-v7a,arm64-v8a,x86,x86_64}
60+
mkdir -p ./aar/jni/{armeabi-v7a,arm64-v8a,x86_64}
6161

6262
cp liblightningjni_release_aarch64-linux-android.so ./aar/jni/arm64-v8a/liblightningjni.so
6363
cp liblightningjni_release_armv7-linux-androideabi.so ./aar/jni/armeabi-v7a/liblightningjni.so
64-
cp liblightningjni_release_i686-linux-android.so ./aar/jni/x86/liblightningjni.so
6564
cp liblightningjni_release_x86_64-linux-android.so ./aar/jni/x86_64/liblightningjni.so
6665
cp ldk-java-classes.jar ./aar/classes.jar
6766

0 commit comments

Comments
 (0)