Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification process interrupted when users (repeatedly) click-on the methods grid #37

Open
jdduh opened this issue Oct 20, 2016 · 10 comments
Labels

Comments

@jdduh
Copy link

jdduh commented Oct 20, 2016

Users who have a slow computer are more likely to encounter this problem. They tried to see the progress of the verification but ended up getting this error message.

image

@lbross
Copy link
Contributor

lbross commented Oct 24, 2016

Do you know what they were doing with the grid? Sorting? clicking the scroll bars? I noticed that the 'use' checkboxes are enabled when the calculation is running which isn't good. I will fix that.

@jdduh
Copy link
Author

jdduh commented Oct 24, 2016

They just wanted to move the scroll bar to view the verification progress.

@lbross
Copy link
Contributor

lbross commented Oct 24, 2016

The good news is, I was able to replicate the behavior. The bad news is, I can't think of a good way to address it. For some reason, when you move the scroll bars around, it sends a cancel message to the Geoprocessor. The Geoprocessor calls a model to create the parameter table. Here is the error message:

GP Msg: Cancelled function
GP Msg: (Table to Table) aborted by User.
GP Msg: Failed at Mon Oct 24 15:43:19 2016 (Elapsed Time: 0.98 seconds)

I can disable the grid while the verification process is running which will prevent the failure, but it also means that the scroll bars won't work 👎

@jdduh
Copy link
Author

jdduh commented Oct 24, 2016

What will happen if the user tries to sort the cells? Could it be that the ValueChanged event of the scrollbar attempts to refresh/reload the gridview? When BAGIS-P calculates the parameters, the scrollbar seems to perform normally so that the users can view the entire method list without cancelling out the calculation.

@lbross
Copy link
Contributor

lbross commented Oct 25, 2016

The sort function causes the error as well. I found that the GP tool that was being used to create the parameter table was called using a different method than we use when calculating the actual parameters. I switched it over to use the same method and I'm no longer getting the error. However, the scrollbars don't seem to work either. I'm not sure why this is different than we see with the parameter calculation.

The original method had a TrackCancel argument that was set to cancel on click. Perhaps this opens the UI up to responding to clicks?

@lbross
Copy link
Contributor

lbross commented Oct 26, 2016

@jdduh I have tried everything I can think of to get the scroll bars to work with the verify button, but they don't work unless the TrackCancel argument accepts clicks and then we get the exception when trying to create the parameters table. OK to close this with scrollbars not usable when verifying?

@jdduh
Copy link
Author

jdduh commented Oct 26, 2016

Is there a way to make it clear to the users that the scrollbar is disabled? For example. grey it out or hide it. How about creating a modal dialog window asking the user to wait? I would like to see the scrollbar remains active during parameter calculations.

@lbross
Copy link
Contributor

lbross commented Oct 26, 2016

Would you prefer hiding the scrollbar or creating a modal dialog window asking the user to wait during verification? I'm not going to do anything with the scrollbar during the parameter calculations because that is currently working as desired.

@jdduh
Copy link
Author

jdduh commented Oct 26, 2016

The verification usually doesn't take very long. How about a modal dialog window, saying "Verifying methods. Please wait!"?

lbross added a commit that referenced this issue Oct 27, 2016
@lbross
Copy link
Contributor

lbross commented Oct 27, 2016

I added a label that overlays the method box with the warning message. Easier than another window and visually pleasing. This will be in the next BAGIS-P releasel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants