Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UrlObject full refactoring #130

Open
4 tasks
PandaHugMonster opened this issue Nov 30, 2022 · 1 comment
Open
4 tasks

UrlObject full refactoring #130

PandaHugMonster opened this issue Nov 30, 2022 · 1 comment
Assignees
@PandaHugMonster
Labels
architecture Architecture related topics code quality Code quality related issue (must not affect architecture) danger documentation Improvements or additions to documentation enhancement New feature or request heavy important model Models urgent

Comments

@PandaHugMonster
Copy link
Owner

PandaHugMonster commented Nov 30, 2022 •
edited
Loading

Specifying/modifying on the fly. Currently only properties are used, and it's not always convenient to set params in place etc.

Additionally should be improved the logic:

  • host can contain all the following values: host, port, path, params and sharpy
  • path can contain all the following values: path, params and sharpy
  • params can contain all the following values: params and sharpy
    - The priority is from top to bottom: host > port > path > params > sharpy
    - All the values within the higher priorities must override/replace values of the lower ones
  • String versions of paths and params must be parsable (Only string values, strings in arrays must be encoded, not parsed)

Diagram explaining the HTTP(S) handling of urls
UrlObject url handling explained
@PandaHugMonster PandaHugMonster pinned this issue Dec 1, 2022
@PandaHugMonster PandaHugMonster added this to the 1.1.5 milestone Feb 19, 2023
@PandaHugMonster PandaHugMonster self-assigned this Feb 19, 2023
@PandaHugMonster PandaHugMonster added enhancement New feature or request architecture Architecture related topics model Models important labels Feb 19, 2023
@PandaHugMonster PandaHugMonster modified the milestones: 1.2.0, 1.2.1 Apr 1, 2023
@PandaHugMonster PandaHugMonster modified the milestones: 1.2.1, 1.1.6 Aug 20, 2023
@PandaHugMonster PandaHugMonster changed the title UrlObject improve usability UrlObject full refactoring Aug 23, 2023
@PandaHugMonster
Copy link
Owner Author

Code quality and lots of inconsistencies must be fixed.

@PandaHugMonster PandaHugMonster added documentation Improvements or additions to documentation code quality Code quality related issue (must not affect architecture) heavy danger urgent labels Aug 23, 2023
PandaHugMonster added a commit that referenced this issue Aug 28, 2023
@PandaHugMonster
#130 / Urls full refactoring
065f973 
Awaiting #164 #165

unfinished
@PandaHugMonster PandaHugMonster unpinned this issue Jul 10, 2024
@PandaHugMonster PandaHugMonster removed this from the 1.1.6 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PandaHugMonster PandaHugMonster

Labels
architecture Architecture related topics code quality Code quality related issue (must not affect architecture) danger documentation Improvements or additions to documentation enhancement New feature or request heavy important model Models urgent
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

130-urlobject-improve-usability PandaHugMonster/php-simputils
1 participant
@PandaHugMonster