Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Header Returned Twice in the Response #594

Closed
omar-m-othman opened this issue May 29, 2014 · 4 comments
Closed

Server Header Returned Twice in the Response #594

omar-m-othman opened this issue May 29, 2014 · 4 comments
Labels
Beginner Suitable Bug

Comments

@omar-m-othman
Copy link
Contributor

The "Server" header is currently returned twice in the response. I fixed #563, so that now it returns the "Server" header either once or twice. So, the duplication is a separate issue.
@omar-m-othman
Copy link
Contributor Author

I'm working on this.

@omar-m-othman
Copy link
Contributor Author

This issue happens because HTTP::Server::PSGI always adds the "Server" header. I've issued plack/Plack#458 to treat that. Once that one is resolved, I'll close this issue.

@xsawyerx
Copy link
Member

Another way to fix this would be to only add the Server header if server_tokens is on and it's not a development environment.

@xsawyerx
Copy link
Member

xsawyerx commented Nov 9, 2014

Fixed and merged already.

@xsawyerx xsawyerx closed this as completed Nov 9, 2014
@jidanni jidanni mentioned this issue Oct 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Suitable Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xsawyerx @omar-m-othman