-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bad initialization for importers #292
Comments
Can you show me how to reproduce, I'm unsure I understand the issue |
Let's say the s3 importe fails during initialization. The error is bubbled up, but then, we fallback to the fs importer in backup.go. As a result, creating a snapshot of an invalid s3 location successfully creates a backup:
|
Yeah it's a known shortcoming of our current (best) heuristic to process both absolute and relative paths for the fs. Not something we can easily fix without doing a full re-make of how we handle backend detection (same goes for repo/exporter). The remake is in a todo list somewhere, but it's def. a post V1 thing. |
In backup.go, we attempt to initialize the importer. In case of failure, we fallback to the fs importer.
If the importer fails because the path given is invalid, we should instead display the error to the user.
The text was updated successfully, but these errors were encountered: