New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review issues #42

Open

5 tasks

notwaldorf opened this issue Aug 10, 2015 · 1 comment

Labels

Contributor

notwaldorf commented Aug 10, 2015

IronControlState review: IronControlState: code review iron-behaviors#27
IronButtonState review: IronButtonState: code review iron-behaviors#28
_computed... methods should have ternary ifs
elevation could have a computed method
calcElevation should be stateless and shouldn't use this

/cc @frankiefu @cdata @sorvell @kevinpschaaf

The text was updated successfully, but these errors were encountered:

Contributor

blasten commented Jan 28, 2016

what the status of this @notwaldorf ?

blasten assigned notwaldorf

blasten added the p1 - backlog label

notwaldorf removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment