Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure ConcurrenyOptions to the CLI #15416

Open
jeanluciano opened this issue Sep 18, 2024 · 0 comments
Open

Add ability to configure ConcurrenyOptions to the CLI #15416

jeanluciano opened this issue Sep 18, 2024 · 0 comments
Assignees
Labels
enhancement An improvement of an existing feature

Comments

@jeanluciano
Copy link
Contributor

jeanluciano commented Sep 18, 2024

Describe the current behavior

Currently users can set the the concurrency_limit for a deployment when creating it with the CLI by specifying the limit with and int as so: `deploy "my-deployment -cl 1".

Upcoming work #15291, adds options for handling concurrency limiting which we will need add to the CLI.

Describe the proposed behavior

I think that it while it's possible to create a custom type in typer and configure them as so deploy "my-deployment" -cl 1 --concurrency-options = {'collisions-strategy' = 'cancel-new'}, it makes for a better user experience if we flatten it. This could be done for each subsequent options that gets added and along with sane defaults, users wouldn't be setting a lot of these.

Example Use

deploy "my-deployment" -cl 42 --collision strategy "cancel-new"

Additional context

No response

@jeanluciano jeanluciano added the enhancement An improvement of an existing feature label Sep 18, 2024
@jeanluciano jeanluciano self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant