Skip to content

Commit cd66718

Browse files
author
Sander Marechal
committedJun 4, 2018
Drop PHP7.1+ only test dependency
1 parent d5abef4 commit cd66718

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed
 

‎Tests/DependencyInjection/PrezentDoctrineTranslatableExtensionTest.php

+4-6
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
namespace Prezent\Doctrine\TranslatableBundle\Tests\DependencyInjection;
44

55
use PHPUnit\Framework\TestCase;
6-
use PackageVersions\Versions;
76
use Prezent\Doctrine\TranslatableBundle\DependencyInjection\PrezentDoctrineTranslatableExtension;
8-
use Composer\Semver\Semver;
97
use Symfony\Component\DependencyInjection\ContainerBuilder;
108

119
class PrezentDoctrineTranslatableExtensionTest extends TestCase
@@ -30,9 +28,9 @@ public function testDefault()
3028

3129
public function testSonataFilter()
3230
{
33-
try {
34-
$sonataVersion = Versions::getVersion('sonata-project/doctrine-orm-admin-bundle');
35-
} catch (\OutOfBoundsException $e) {
31+
$sonataVersion = getenv('SONATA');
32+
33+
if (!$sonataVersion) {
3634
$this->markTestSkipped('Sonata is not installed.');
3735
return;
3836
}
@@ -43,7 +41,7 @@ public function testSonataFilter()
4341
$extension = new PrezentDoctrineTranslatableExtension();
4442
$extension->load([[]], $container);
4543

46-
if (Semver::satisfies($sonataVersion, '^3.0')) {
44+
if ($sonataVersion == '^3.6') {
4745
$this->assertTrue($container->hasDefinition('prezent_doctrine_translatable.sonata.filter'));
4846
} else {
4947
$this->assertFalse($container->hasDefinition('prezent_doctrine_translatable.sonata.filter'));

‎composer.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@
3131
"symfony/http-kernel": "^2.7|^3.0|^4.0"
3232
},
3333
"require-dev": {
34-
"symfony/phpunit-bridge": "^4.1",
35-
"composer/semver": "^1.4",
36-
"ocramius/package-versions": "^1.3"
34+
"symfony/phpunit-bridge": "^4.1"
3735
},
3836
"autoload": {
3937
"psr-4": { "Prezent\\Doctrine\\TranslatableBundle\\": "" }

0 commit comments

Comments
 (0)
Please sign in to comment.