From 7a6b69fc22b25fbdc747e0e6d28f85c90947cfd4 Mon Sep 17 00:00:00 2001
From: Han Wang <freddie.wanah@gmail.com>
Date: Fri, 19 Apr 2024 10:15:38 +0100
Subject: [PATCH] Adapt to use assert raises (#7670)

### Description

Some test cases use try/except command, instead of catch exceptions with
assertRaise. This will cause extra execution time according to the
experimental tests.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Han Wang <freddie.wanah@gmail.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
---
 tests/test_decathlondataset.py | 5 +----
 tests/test_mednistdataset.py   | 5 +----
 tests/test_monai_utils_misc.py | 9 ++++-----
 tests/test_tciadataset.py      | 4 +---
 4 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/tests/test_decathlondataset.py b/tests/test_decathlondataset.py
index d220cd9097..70a2a6c06c 100644
--- a/tests/test_decathlondataset.py
+++ b/tests/test_decathlondataset.py
@@ -80,7 +80,7 @@ def _test_dataset(dataset):
         self.assertDictEqual(properties["labels"], {"0": "background", "1": "Anterior", "2": "Posterior"})
 
         shutil.rmtree(os.path.join(testing_dir, "Task04_Hippocampus"))
-        try:
+        with self.assertRaisesRegex(RuntimeError, "^Cannot find dataset directory"):
             DecathlonDataset(
                 root_dir=testing_dir,
                 task="Task04_Hippocampus",
@@ -88,9 +88,6 @@ def _test_dataset(dataset):
                 section="validation",
                 download=False,
             )
-        except RuntimeError as e:
-            print(str(e))
-            self.assertTrue(str(e).startswith("Cannot find dataset directory"))
 
 
 if __name__ == "__main__":
diff --git a/tests/test_mednistdataset.py b/tests/test_mednistdataset.py
index baf3bf4f2d..1db632c144 100644
--- a/tests/test_mednistdataset.py
+++ b/tests/test_mednistdataset.py
@@ -65,11 +65,8 @@ def _test_dataset(dataset):
         self.assertEqual(data[0]["class_name"], "AbdomenCT")
         self.assertEqual(data[0]["label"], 0)
         shutil.rmtree(os.path.join(testing_dir, "MedNIST"))
-        try:
+        with self.assertRaisesRegex(RuntimeError, "^Cannot find dataset directory"):
             MedNISTDataset(root_dir=testing_dir, transform=transform, section="test", download=False)
-        except RuntimeError as e:
-            print(str(e))
-            self.assertTrue(str(e).startswith("Cannot find dataset directory"))
 
 
 if __name__ == "__main__":
diff --git a/tests/test_monai_utils_misc.py b/tests/test_monai_utils_misc.py
index a2a4ed62f7..f4eb5d3956 100644
--- a/tests/test_monai_utils_misc.py
+++ b/tests/test_monai_utils_misc.py
@@ -92,12 +92,11 @@ def test_run_cmd(self):
         cmd2 = "-c"
         cmd3 = 'import sys; print("\\tThis is on stderr\\n", file=sys.stderr); sys.exit(1)'
         os.environ["MONAI_DEBUG"] = str(True)
-        try:
+        with self.assertRaises(RuntimeError) as cm:
             run_cmd([cmd1, cmd2, cmd3], check=True)
-        except RuntimeError as err:
-            self.assertIn("This is on stderr", str(err))
-            self.assertNotIn("\\n", str(err))
-            self.assertNotIn("\\t", str(err))
+        self.assertIn("This is on stderr", str(cm.exception))
+        self.assertNotIn("\\n", str(cm.exception))
+        self.assertNotIn("\\t", str(cm.exception))
 
 
 if __name__ == "__main__":
diff --git a/tests/test_tciadataset.py b/tests/test_tciadataset.py
index d996922e20..5a16bb4816 100644
--- a/tests/test_tciadataset.py
+++ b/tests/test_tciadataset.py
@@ -108,7 +108,7 @@ def _test_dataset(dataset):
             )[0]
 
         shutil.rmtree(os.path.join(testing_dir, collection))
-        try:
+        with self.assertRaisesRegex(RuntimeError, "^Cannot find dataset directory"):
             TciaDataset(
                 root_dir=testing_dir,
                 collection=collection,
@@ -117,8 +117,6 @@ def _test_dataset(dataset):
                 download=False,
                 val_frac=val_frac,
             )
-        except RuntimeError as e:
-            self.assertTrue(str(e).startswith("Cannot find dataset directory"))
 
 
 if __name__ == "__main__":