Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError in TestSURELoss #8036

Open
KumoLiu opened this issue Aug 21, 2024 · 3 comments
Open

AssertionError in TestSURELoss #8036

KumoLiu opened this issue Aug 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 21, 2024

======================================================================
FAIL: test_complex_general_input (tests.test_sure_loss.TestSURELoss)
Test SURELoss with complex-valued input: when the input is general complex value, the loss should be 0.0.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/MONAI/MONAI/tests/test_sure_loss.py", line 68, in test_complex_general_input
    self.assertAlmostEqual(loss_real.item(), loss_complex.abs().item(), places=6)
AssertionError: 2.323428153991699 != 2.3234288692474365 within 6 places (7.152557373046875e-07 difference)

----------------------------------------------------------------------

https://github.com/Project-MONAI/MONAI/actions/runs/10475022817/job/29010724209?pr=8021

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Aug 21, 2024

Hi @cxlcl, could you please help take a look at the issue, seems like a random issue? There doesn't seem to be much of a difference, more like a precision issue. Do you think we can modify the places to be 7 here? Thanks.

@cxlcl
Copy link
Contributor

cxlcl commented Aug 21, 2024

Yes, it should be a precision issue, and it should a random issue as well. So we can modify it to be 7 or more.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Aug 21, 2024

Do you think it make sense we can modify the places to be 7 here?

@KumoLiu KumoLiu added the bug Something isn't working label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants