Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solves path problem in test_bundle_trt_export.py #8357

Merged
merged 15 commits into from
Feb 20, 2025
Merged

Solves path problem in test_bundle_trt_export.py #8357

merged 15 commits into from
Feb 20, 2025

Conversation

garciadias
Copy link
Contributor

@garciadias garciadias commented Feb 19, 2025 •
edited by KumoLiu
Loading

Fixes #8354 #8353

Description

Fixes path on test that is only run on special conditions.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@ericspod ericspod requested review from ericspod and KumoLiu February 19, 2025 11:04
@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 19, 2025

/build

ericspod
ericspod approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if you could do the DCO remediation and blossom passes we're good to go.

@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 19, 2025

Hi @garciadias, could you please try the guide here to resolve the DCO issue? Thanks!
https://github.com/Project-MONAI/MONAI/pull/8357/checks?check_run_id=37458980383

garciadias and others added 3 commits February 19, 2025 16:21
@garciadias
DCO Remediation Commit for R. Garcia-Dias <[email protected]>
99dce14 
     I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: ba56a6d
     I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: da29d2f
     I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: 93f16db

     Signed-off-by: R. Garcia-Dias <[email protected]>

Signed-off-by: R. Garcia-Dias <[email protected]>
@garciadias
Add dict_product utility for test case generation
2549bbb 
- Introduced a new `dict_product` function to create combinations of input parameters.
- Updated test cases to use the new utility for generating shape and input type combinations.
- Cleaned up code by removing old nested loops in favor of the new function.
@KumoLiu
Merge branch 'dev' into 8354_fix_test_bundle_trt_export
75b4279
@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 20, 2025

The DCO issue is still unresolved, and it's not clear if it's due to inappropriate indentation. If you can add sigh off to every commit later, you might be able to avoid the such kind of issue.

@garciadias
DCO Remediation Commit for R. Garcia-Dias <[email protected]>
679ac3c 
I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: ba56a6d
I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: da29d2f
I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: 93f16db

Signed-off-by: R. Garcia-Dias <[email protected]>

Signed-off-by: R. Garcia-Dias <[email protected]>
@garciadias
Add dict_product utility for test case generation
f5ac534 
- Introduced a new `dict_product` function to create combinations of input parameters.
- Updated test cases to use the new utility for generating shape and input type combinations.
- Cleaned up code by removing old nested loops in favor of the new function.
@garciadias
Merge remote-tracking branch 'origin/8354_fix_test_bundle_trt_export'…
3775cd2 
… into 8354_fix_test_bundle_trt_export
@garciadias
Copy link
Contributor Author

The DCO issue is still unresolved, and it's not clear if it's due to inappropriate indentation. If you can add sigh off to every commit later, you might be able to avoid the such kind of issue.

I am sorry about that. I think it is fixed now. I set it up to sign every commit, but it's not working correctly. I will solve this to make sure all commits are signed from now on.

@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 20, 2025

I am sorry about that. I think it is fixed now. I set it up to sign every commit, but it's not working correctly. I will solve this to make sure all commits are signed from now on.

Great, it fixed for yesterday's four commits. But just now you push two commits without sighoff. The DCO will check each commit in the PR. :)

garciadias and others added 3 commits February 20, 2025 10:20
@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 20, 2025

/build

@KumoLiu KumoLiu enabled auto-merge (squash) February 20, 2025 12:28
@KumoLiu KumoLiu merged commit d98f348 into Project-MONAI:dev Feb 20, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod approved these changes

@KumoLiu KumoLiu Awaiting requested review from KumoLiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileNotFoundError in test_bundle_trt_export
3 participants
@garciadias @KumoLiu @ericspod