-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed outdated torch
version checks from transform functions
#8359
Removed outdated torch
version checks from transform functions
#8359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good, if we're through the tests and blossom we can merge, thanks!
The DCO issue should be fixable through the instructions it gives for a remedial commit. |
Signed-off-by: Nicolas Kaenzig <[email protected]>
Signed-off-by: Nicolas Kaenzig <[email protected]>
I, Nicolas Kaenzig <[email protected]>, hereby add my Signed-off-by to this commit: c040d85 Signed-off-by: Nicolas Kaenzig <[email protected]>
Signed-off-by: Nicolas Kaenzig <[email protected]>
I, Nicolas Kaenzig <[email protected]>, hereby add my Signed-off-by to this commit: 33e1c66 Signed-off-by: Nicolas Kaenzig <[email protected]>
@ericspod Thanks for the review. After a couple of attempts I managed to fix the DCO :D |
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix, LGTM.
Hi @nkaenzig we weren't planning a release soon since we're working on things for a proper 1.5 release. We've removed things already that shouldn't go until 1.5 so a patch release now may be a problem. If you want the fixes to use immediately you can install MONAI from the git repo using pip or install |
Fixes #8348
Description
Support for
torch
versions prior to1.13
has been dropped, so those1.8
version checks are not required anymore. Furthermore, as reported in the issue description, those checks led to unstable behaviour when using certain transforms in data pipelines.Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.