Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed outdated torch version checks from transform functions #8359

Conversation

nkaenzig
Copy link
Contributor

Fixes #8348

Description

Support for torch versions prior to 1.13 has been dropped, so those 1.8 version checks are not required anymore. Furthermore, as reported in the issue description, those checks led to unstable behaviour when using certain transforms in data pipelines.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, if we're through the tests and blossom we can merge, thanks!

@ericspod
Copy link
Member

The DCO issue should be fixable through the instructions it gives for a remedial commit.

@ericspod ericspod requested a review from KumoLiu February 19, 2025 15:19
Signed-off-by: Nicolas Kaenzig <[email protected]>
Signed-off-by: Nicolas Kaenzig <[email protected]>
I, Nicolas Kaenzig <[email protected]>, hereby add my Signed-off-by to this commit: c040d85

Signed-off-by: Nicolas Kaenzig <[email protected]>
Signed-off-by: Nicolas Kaenzig <[email protected]>
I, Nicolas Kaenzig <[email protected]>, hereby add my Signed-off-by to this commit: 33e1c66

Signed-off-by: Nicolas Kaenzig <[email protected]>
@nkaenzig
Copy link
Contributor Author

@ericspod Thanks for the review. After a couple of attempts I managed to fix the DCO :D

@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 19, 2025

/build

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, LGTM.

@KumoLiu KumoLiu enabled auto-merge (squash) February 19, 2025 16:01
@KumoLiu KumoLiu merged commit fb8c5bf into Project-MONAI:dev Feb 19, 2025
28 checks passed
@nkaenzig nkaenzig deleted the fix/remove-torch-version-check-from-transform-functions branch February 20, 2025 14:26
@nkaenzig
Copy link
Contributor Author

@ericspod @KumoLiu Thanks a lot for the quick review & merge process. I wanted to ask if it would be possible to do a new release soon which includes those changes?

@ericspod
Copy link
Member

@ericspod @KumoLiu Thanks a lot for the quick review & merge process. I wanted to ask if it would be possible to do a new release soon which includes those changes?

Hi @nkaenzig we weren't planning a release soon since we're working on things for a proper 1.5 release. We've removed things already that shouldn't go until 1.5 so a patch release now may be a problem. If you want the fixes to use immediately you can install MONAI from the git repo using pip or install monai-weekly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RandCropByPosNegLabeld can lead to memory overflow
3 participants