Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export test function #55

Closed
rom1504 opened this issue Feb 26, 2016 · 4 comments
Closed

Export test function #55

rom1504 opened this issue Feb 26, 2016 · 4 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Feb 26, 2016

Would be interesting to somehow export the test functions to make it easy to add tests for protodef users (to add tests for https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/datatypes/minecraft.js )

follows #54

@rom1504
Copy link
Member Author

rom1504 commented Mar 1, 2016

I see 2 ways to do this:

  1. put the test function in its own package (and repo I guess)
  2. add jsonschema as a dependency to protodef (it's pretty small and has no dependencies) and add the test function in lib/ and expose it as part of protodef

The second way seems simpler. I might use jsonschema to provide validation functionality anyway (#46 (comment) )

@rom1504
Copy link
Member Author

rom1504 commented Mar 1, 2016

I think stuff would be clearer if an other implementation would be started (#59) because it would requires to depend on an interlanguage repo containing the json tests.

Is it okay for an implementation to provide its own test suite or should it be independent ?

@rom1504
Copy link
Member Author

rom1504 commented Mar 3, 2016

I like the way this org is organized https://github.com/JSONScript/jsonscript-test-suite

@rom1504
Copy link
Member Author

rom1504 commented Feb 26, 2017

well this is long done.

@rom1504 rom1504 closed this as completed Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant