Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch_review-3.0.1 LaunchReviewPlugin.java uses or overrides a deprecated API. #39

Open
psdike opened this issue Jul 27, 2021 · 2 comments

Comments

@psdike
Copy link

psdike commented Jul 27, 2021

Hi, I am using this plugin for many of my applications.
But now from last two apps I got this Note which is irritate me even my all plugins have updated version, flutter showing this note.
Please check and let me know how to solve this.

@lukaskurz
Copy link
Contributor

lukaskurz commented Sep 16, 2021

Same here

/home/lukaskurz/.pub-cache/hosted/pub.dartlang.org/launch_review-3.0.1/android/src/main/java/com/iyaffle/launchreview/LaunchReviewPlugin.java:11: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
/home/lukaskurz/.pub-cache/hosted/pub.dartlang.org/launch_review-3.0.1/android/src/main/java/com/iyaffle/launchreview/LaunchReviewPlugin.java:41: warning: [deprecation] Registrar in PluginRegistry has been deprecated
    public static void registerWith(Registrar registrar) {
                                    ^
2 warnings

I am guessing this has to do with the backwards compatibility to v1 embedding, since registerWith and Registrar is no longer used in v2 embedding. The official guide for migrating to v2, still recommends keeping this for backwards compatibility.

Therefore I would recommend adding @SuppressWarnings("deprecation") above the function, as many other libraries do the same.

@lukaskurz
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants