Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax Expronicon for ZXCalculus #7

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

exAClior
Copy link
Contributor

Hello, could you please relax the version requirement for Expronicon.jl? I need the latest version to work on ZXCalculus.jl. I ran the test and it passed with no error.

If possible, could you please also bump the version? Thanks a lot!

@Roger-luo
Copy link
Member

There might be API changes, let's run tests to see what's breaking and maybe you can update those breaking APIs accordingly

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.67 ⚠️

Comparison is base (cc5eca8) 67.32% compared to head (fa358c5) 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   67.32%   66.66%   -0.67%     
==========================================
  Files           3        4       +1     
  Lines         101      105       +4     
==========================================
+ Hits           68       70       +2     
- Misses         33       35       +2     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Roger-luo Roger-luo merged commit 9c26286 into QuantumBFS:master Jun 23, 2023
@exAClior
Copy link
Contributor Author

those

Sure thing, I will be happy to do so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants