Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Usage/Installation method which does not require a node env #67

Open
thomasfr opened this issue Jun 28, 2024 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@thomasfr
Copy link

In CI/CD environments it would be handy to have an alternative installation method which does not require to have a running node and npm, pnpm, yarn, etc. setup in place. This would greatly reduce CI/CD setup time.

For instance for biome we can do:

jobs:
  quality:
    name: Quality Checks
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: biomejs/setup-biome@v2
      - run: biome ci . --reporter=github

and this finished usually within 5-7 seconds, whereas the setup of node and a package manager alone takes often times between 15-20 seconds. Its not much difference, but since sherif is a binary anyways, it would be an easy win.

@AlemTuzlak
Copy link

This would be an amazing thing to have!

@AlemTuzlak
Copy link

https://github.com/biomejs/setup-biome/blob/main/src/setup.ts#L41 Here is the biome source code for this, I think this would just be adapted to sherif for it to work

@QuiiBz
Copy link
Owner

QuiiBz commented Jun 28, 2024

That's a good idea! Will take a look this weekend.

@QuiiBz QuiiBz added the enhancement New feature or request label Jun 28, 2024
@QuiiBz
Copy link
Owner

QuiiBz commented Aug 10, 2024

[email protected] was just released and now contains the binaries in the GitHub release, so we should be able to do something similar as https://github.com/biomejs/setup-biome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants