Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming convention for presence and status #23

Open
Lunaphied opened this issue Jul 7, 2024 · 0 comments
Open

Inconsistent naming convention for presence and status #23

Lunaphied opened this issue Jul 7, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Lunaphied
Copy link
Collaborator

Currently, Discord has two concepts in it's API: status (online/offline/dnd/idle/invisible), and activities (" is playing a game", etc.). Together these are referred to by Discord as the user's "presence".

Internally we mostly refer to Discord's "status" as a "presence", except in a few spots we've started to call it "status" again.

Especially confusingly, we consistently refer to Discords "activities" as a "status", which now collides with our own internal concept called "status", which makes parsing through this logic especially difficult.

These should be reconciled into a single concept, likely matching the Discord provided names as that will match both the API documentation for Discord itself and discord.py's documentation.

@Lunaphied Lunaphied added bug Something isn't working good first issue Good for newcomers labels Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant