Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSGalleryModule - Make ApiKey optional #97

Closed
ghost opened this issue Aug 29, 2017 · 4 comments
Closed

PSGalleryModule - Make ApiKey optional #97

ghost opened this issue Aug 29, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 29, 2017

Similar to #72
Can we make the ApiKey parameter optional? Some repositories do not require a key, and this blocks me from being able to publish a module to our internal repository.

For that, the NuGetAPIKey parameter in the Publish-Module @params (Line 47 of PSGalleryModule.ps1) would need to be removed/modified.

Any thoughts on how you'd like to proceed?

Thanks!

@devblackops
Copy link
Contributor

I'm OK with making ApiKey an optional parameter. Thoughts @RamblingCookieMonster?

@commanderpoop, would you like to put in a PR with the changes?

@RamblingCookieMonster
Copy link
Owner

Thanks for the ping @devblackops!

@commanderpoop - makes sense to me, if you're up for a pull request, that would be awesome! Maybe just remove mandatory param attribute, conditionally add to params hash?

Cheers!

@ghost
Copy link
Author

ghost commented Sep 8, 2017

Here you go! #99

@RamblingCookieMonster @devblackops

@RamblingCookieMonster
Copy link
Owner

Closing this out, thanks for submitting the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants