Filter out jakarta @Valid annotations #195
Open
+30
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although validation using the Jakarta validation API is not yet supported (it would require a Hibernator version bump and likely migration away from javax validation), this adds a dependency on it to test filtering out Jakarta @Valid annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the record processor to filter out
@Validannotations from both javax/jakarta, which fixes #189. I also added tests for both.Note: this doesn't add support for validation using Jakarta, since that would require bumping the Hibernator version and changes to the validator/additional validators to preserve support for both validation APIs.