-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: API status banner #191
Comments
The API is inaccessible if it timeouts or returns anything other than a non-OK response. In both cases, a dedicated banner message should be shown. In addition to the API being down, an offtopic idea can be to cache API responses in case the API is inaccessible. |
From what I understand this isn't a simple change. There is no centralized place or store to check the status from. It might require wrapping every API call or something. |
We have this https://api.revanced.app/v2/ping endpoint which we can use, we can ping it on website initial load and check the status code If the status code is unexpected, we can display a banner above the navbar |
Seems like the endpoint is currently broken, will open an issue in the API repository |
The API expects a HEAD request |
Right |
I think at the top is not the best choice, because if you add the element everything in the page is shifted downwards, and if you make the element fixed, it'll cover the navbar buttons. I think a fixed banner at the bottom of the page is ideal, even better with a close button which will keep it closed until the site is refreshed |
If the API is down the website won't work as expected & if the banner is at the bottom it wont be noticed, especially on mobile. Additionally, eventually with announcements being shown on Website, for the latest one, we would reuse the banner to display the announcement & if the banner would be at the bottom, it would be inconsistent, since announcements would be shown at the top, or if at the bottom, go unnoticed once again |
Display a banner at the top of the webpage if the API is down/inaccessible
The text was updated successfully, but these errors were encountered: