-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any support/plan of Privacy Manifest? #2567
Comments
+1 |
1 similar comment
+1 |
Agree that this needs to be added, there are still a lot of apps using RxSwift I think. |
Definitely something we'll add by the deadline. There's almost a year by then. Thanks! |
If one of you who has already looked into this could add it, that would be fantastic. If you have any questions about the library itself. Reach out to me on Slack. |
Yeah, actually if anyone wants to open a relevant PR that would help immensely 🙏 thanks! Here's an example, even though RxSwift doesn't track anything or does any API calls on its own, so there's really no privacy content to describe: https://github.com/BranchMetrics/ios-branch-sdk-spm/blob/main/BranchSDK/PrivacyInfo.xcprivacy |
I simply looked it up, and it seems like 'mach_absolute_time' is used, did I make a mistake? |
Might be missing something but what's the privacy concern with mach time ? |
Not a problem. It just needs a reason for being there.
|
Oh, I'm afraid I didn't say it correctly. It's my mistake to say "problem." I mean... @freak4pc said 'so there's really no privacy content to description', shouldn't we write down the description in PrivacyInfo if RxSwift use 'mach_absolute_time'?? |
Yes, the description needs to be added to the privacy info. I provided you the description above. |
if For reference, this is a PR of Kingfisher, adding privacy manifest to the project: I can try to work on this on the 1st week of 2024, if anyone is free to work it out these days, feel free to create a PR. |
Apple specifically mentioned RxSwift, but within the RxSwift ecosystem, there are various related libraries like RxCocoa, RxRelay, RxBlocking, RxTest, and RxSwift-Dynamic, among others. The question is whether you should include PrivacyInfo documentation for each of these libraries separately or if a single PrivacyInfo entry is sufficient. (Use Chat GPT for translation) |
According to the Apple's Article: If that's the case, I think adding privacy files to these 3 libraries should do the job? |
Thank you so much for your quick response. I have another question about Privacy Manifest, not Rx content...
What happens to each of the above situations? As far as I know, Privacy Manifest is compulsory for third-party libraries, but when I look at other library communities, I'm confused because some places can't even be mentioned. |
May I know the reference from Apple that Privacy Manifest is compulsory for 3rd party libraries? According to my understanding, only the SDKs mentioned by Apple on the list are compulsory to add privacy manifests. Or else you cannot perform App Submissions. |
It is part of the contents of the above document. The contents that can be included in 'PrivacyInfo' are as follows. However, in the case of 'NSPrivacyAccessAPType', the document had the above contents. I understood that, 'All third party libraries should add Privacy Manifest if they have a 'Describing use of required reason API'. Did I get it too differently? |
Agree on this. But I think Apple understands that a massacre will be summoned if they enforce all 3rd party libraries need to add Privacy Manifest lol. So that's why they provided a list of must-provide SDKs. A bit off-topic. I will try to add a privacy manifest to the 3 repositories mentioned by Apple next week. Please feel free to provide info related to this issue, thanks. |
Seems @wlxo0401 has created a PR (as mentioned above), please feel free to take a look. |
Actually, all libraries or SDK which use this functions Apple Doc have to add Privacy Manifest, Apple just mentioned few of them which are common libraries, so all SDK developers should review their own SDK whether they are mentioned by Apple or not. CMIIW |
Agree on this. But then Apple announced a list(on early December 2023) of libraries/SDK that need to add privacyInfo, or else the app cannot submitted to app store. That's why I used the word compulsory in the statement. Clarify one thing is, I agree that eventually all 3rd party SDK may need to add the file. I just worried about the long-term ongoing progress of the review process. Thanks for the info @lambda123254! Much appreciated. |
I discovered a new while testing. Until now, most of the libraries that have added PrivacyInfo have not been marked in PrivacyReport. However, when an item is added to the 'Privacy Nutrition Label Types', the library name is displayed in the PrivacyReport. Many libraries have updated PrivacyInfo without adding anything from 'Privacy Nutrition Label Types'. Does anyone know about this? Is 'Privacy Nutrition Label Types' a must-have item? Or is it not necessary to display it in the privacy report? Please feel free to leave opinion. (I used a translator.) |
I guess this is something from HealthKit, where this type of info should treated properly? |
I didn't use HealthKit. The comment I posted seems to have a translation error, so I corrected it again.😭 |
May I know wdym by PrivacyReport? Thanks. |
The 'PrivacyReport' I'm talking about can be downloaded as a PDF if you archive the app. https://developer.apple.com/videos/play/wwdc2023/10060/
|
@freak4pc @danielt1263 If this is not enough for you to make right decision, just show care about all these thousands of developers who use your SDK. Huge amount of apps that use RxSwift faced this challenge of figuring out how to deal with this new Apple requirement. I have 5 apps in the App Store. Each of them uses dozens of SPM dependencies. Each of them receive warnings from Apple about missing API declarations. Instead of looking for a needle in a haystack I would prefer that every SDK developer tell me whether they use these APIs or not. |
Wow, you are amazingly rude. We've been maintaining this project for years and putting our heart into it, using ridiculous claims like "showing care for developers" is amazingly detached from reality. I don't know who you are, I've never seen you contribute a single line of code to this project aside for coming here with demands without reading any part of this discussion. If the decision we took (after consulting the documentation and available online resources) does not suit you, feel free to fork the repo, add an empty manifest and link your apps towards your fork. The project is open and you're free to do so. For now, the yellow block you screenshotted links to the same section I mentioned earlier that shows this manifest requirement in our case is only required for entirely new apps that add RxSwift or updates of apps that add RxSwift (but didn't have it before). We've also linked to the DTS answer that mentions there is no need to add an empty manifest if you have nothing to declare. Beyond that, I really have nothing else to add to this discussion anymore. We might make a change if Apple answers our DTS but we have not heard back from them so far, we might also make a change at our own discretion (mainly to stop this ridiculous discussion). There is currently no reasoning / guidance of doing what you suggested, the fact you have 5 apps to deal with is not a reason for me to change my answer. I'm maintaining plenty of apps that use RxSwift heavily and am taking the same decision into my projects as well :) Also, as I've noted, our own app has RxSwift in the App Store with no privacy warnings. |
You are misinterpreting the text and not referring at all to the huge document with specifications they sent, but I have wasted enough energies on this discussion with you at this point :) As I mentioned, there is absolutely no problem or difficulty with forking the repo and add or remove whatever portions of code you want to it if you're interpreting the situation any differently. We'll be monitoring what happens to releases in May and if there is any issues / report of an issue. As mentioned numerous times before, if there will be any issue we will immediately remedy with whatever is needed. Thanks. |
We've added self-signed binary signatures starting with RxSwift 6.7.0. Another option is creating your own xcframework(s) so you don't have any worries or needs for signatures to begin with :) You can verify the fingerprint matches the one we provide, in Xcode: We've listed the fingerprint with additional instructions in the README, here: More on how this works, here: |
I've read all the responses in the above discussion, and I'm a bit confused. I have a new app that is about to be released on the App Store before May 1st, and I've used RxSwift. It seems that I should add an empty privacy file? However, according to DTS's answer, I shouldn't do that. Now I'm unsure what to do. I am not a native English speaker, the content above is based on translation. |
I've process my app with all those privacy's problem to review and pass yesterday(prj use RxSwift, and do nothing). doesn't get the privacy warring email, it's that safe? |
@linhaosunny If you didn't get an email before May 1st, you should see no problem. |
@yly6518 @linhaosunny To my understanding, @wlxo0401's comment is correct. If you got no e-mail you should be fine. |
@freak4pc Not really related to privacy manifest but to signature: |
Thank you for your reply :) |
Can you try again? Seems like a weird hiccup, I uploaded a new zip on the latest version. |
It works now thank you! |
We talked to the Apple Review Team and they very clearly confirmed multiple times that if you do not receive any warnings after submitting your app for AppStore or external TestFlight review now, then you will not be blocked after 1st of May due to required reason API violations (assuming you don't change anything in your code). Hope this helps in calming some people here. |
Glad they are answering some people 🤣 |
They currently offer consultation calls here for a limited time about AppStore Review changes. You can also sign up there, even for before May 1st still. |
Definitely useful, Apple is finally answering people lol |
Now it's May 1st. |
We've had no review issues. |
I'm closing this issue for now, If anything arises feel free to comment and I can reopen. |
Same here, submitted an app with RxSwift with no issues at all. |
Following the same topic in RxSwift offical slack. According to the definition of "third-party SDKs" that as mentioned in the WWDC23, new documents: Privacy manifest files | Apple Developer Documentation and the new announcement from Apple. It seems like RxSwift/RxCocoa/RxRelay require a privacy manifest and signature as well.
I was wondering if the Privacy Manifest update will be introduce in following updates, and, whether it is possible for us to know the schedule so that we can plan and manage our app releases more effectively.. Deeply appreciated.
Platform/Environment
Installation method:
Level of RxSwift knowledge:
(this is so we can understand your level of knowledge
and formulate the response in an appropriate manner)
The text was updated successfully, but these errors were encountered: