Fixed defaultIfEmpty incorrect type with strictNullChecks off #7287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
defaultIfEmpty(null)
ordefaultIfEmpty(undefined)
always returns the observable of typeObservable<any>
Expected behavior
When strictNullChecks is off null type is ignored so it should just return the type of the source observable as it is.
Expected behaviour in
strictNullChecks: false
const test$ = of(1).pipe(defaultIfEmpty(null)); // Observable<number>
Instead we get
const test$ = of(1).pipe(defaultIfEmpty(null)); // Observable<any>
This PR fixes the issue by adding explicit overloads for null and undefined
Related issue (if exists): #7280